db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kathey Marsden <kmars...@Sourcery.Org>
Subject Re: [PATCH] Network Server DRDA XAMGR Level 7 Support (Server only)
Date Thu, 09 Dec 2004 01:29:25 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kathey Marsden wrote:
>> Army wrote
>>>-- Would it be worth it to call "getXAResource" a single time in the
>>>DRDAXAProtocol constructor, and then reuse it, instead of having to
>>>repeatedly do the work of "((XADatabase)
>>>connThread.getDatabase()).getXAResource();"  Or would that break
>
> something?
>
> I thought it better not to have another reference to  the XAResource in
> the DRDAXAProtocol class. I think traditionally we have just tried to
> keep the database as the only state in the DRDAConnectionThread since it
> would add to the cleanup.   I think it brings up a good point though. I
> should move the actual XA actions into the XADatabase class so that we
> don't have to do this.   I'll handle it that way.
>

Well this idea wasn't such a  swell idea.    I'd still have to do the
cast.
Maybe I'll leave it like it is for now unless someone has a better idea.

I've got the other changes made as described in earlier emails.    I'll
test tonight and send a patch with this item  unchanged unless anyone
has further input on this or any of the other issues.

Thanks

Kathey

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBt6p0G0h36bFmkocRAoIMAKDJQ8ZZO4cQ5c13I/DoRvaZ6+GjuwCgjnOg
6GAxDIBijsz4eZ1KZN8s/Fs=
=wK2Q
-----END PGP SIGNATURE-----

Mime
View raw message