db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: svn native eol
Date Wed, 01 Dec 2004 21:57:42 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

scott hutinger wrote:
> I changed all of the framework files to native eol, and it generates a
> LARGER patch file (diff) of course; removing ^M at the end, which means
> the entire file is patched.
>
> -rw-rw-r--  1 srh  srh    70121 Dec  1 12:35 /home/srh/derby1.patch
> -- with native
> -rw-rw-r--  1 srh  srh    30131 Dec  1 09:00 /home/srh/derby.diff
>     -- without native
>
> I don't think we want patch files that modify an entire file, as it
> really makes changes hard to find.

I think the correct approach is to set the property on the same type of
system as the files were originally added into svn from. In this case
only the propery is changed, the contents of the file remains unchanged
as it already has the correct endings. This is what I did for the .java
files after the original contribution.

I also made sure that setting the property was the only change, not to
mix it with other unrelated diffs.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBrj5WIv0S4qsbfuQRAsk1AKDVYmr700KV1gOTl0aDkXPv2QxU4QCfagdF
sFVx6iKYw8SfuELcJnsJEh4=
=G0gy
-----END PGP SIGNATURE-----


Mime
View raw message