db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Sitsky <s...@users.sourceforge.net>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Fri, 17 Dec 2004 00:34:10 GMT
On Fri, 17 Dec 2004 03:21, Philipp Hug wrote:
> here it is: patch is against trunk in svn revision 111709, because
> svn.apache.org seems to be down at the moment...
> one important thing: please make sure that DB2Limits.java is renamed to
> DerbyLimits.java in subversion and not just deleted and added again..
> otherwise history of the file will be lost
>
> philipp

Just as a complete aside, it might make life a bit easier to review code 
using a proper code reviewing system rather than using an email client.

One possibility might be to use something like Codestriker, which is an 
open-source code reviewing system (disclaimer, I am one of the authors).
See http://codestriker.sourceforge.net for more info.

For this patch submitted by Philipp, I created a topic at:

http://codestriker.sourceforge.net/cgi-bin/codestriker.pl?topic=8845587&action=view

Its not very fast, as its hosted on a Sourceforge server, but speed is not 
an issue when properly deployed.  You can see the diff far more clearly, 
and you can add comments on a per-line basis, emails will get sent 
appropriately, and everything is recorded in the topic, within a database, 
so the author can work through the issues raised, and flag them when they 
are done.

Whenever somebody creates a new patch, they could create a topic and CC the 
derby-dev list, so anybody can come along and review it.

If this is of interest to people, you could deploy Codestriker on a server 
which can access the Derby svn repository (the SF server blocks this), so 
that you can click on the "Line" and "Parallel" links so that you can view 
an entire file with the changes applied, rather than just the diff chunks.  
Check out the following topic to see what I mean:

http://codestriker.sourceforge.net/cgi-bin/codestriker.pl?topic=7063366&action=view

Again, if this is of interest, we could write a Jira plugin module, so that 
whenever a new review was created, we could automatically update the 
appropriate JIRA record, with a link to this review.

Anyway - just my Aussie 2c - for what its worth. :)

-- 
Cheers,
David


Mime
View raw message