db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "RPost" <rp0...@pacbell.net>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Thu, 16 Dec 2004 20:55:52 GMT
> Dan wrote:
>
> I would strongly advise against any attempt to do a global search and
> replace. Having renamed this product more times than I care to remember,
> I've found that such generalized cleanups tend to mess things up.

Let me clear up any confusion my comments may have caused.

I didn't propose a global search and replace. Global search and replace is
rarely
appropriate for software for exactly the reasons Dan expoused.

Once software is in production NOTHING should be changed without a
legitimate or demonstrated need. This includes code, terminology and
documentation.

When I said 'if a term is going to be changed it should be changed
globally.' I mean that
all uses of the term need to be examined to see if they need to be changed
also. I only saw
references to 2 java files that would be affected by the proposed patch.

I found 30 files that reference the term 'DB2Limit'. I examined a few of
these and they
clearly need to be changed. In my opinion ALL of the files that include the
term and all
of the references to the term in the files need to be examined to see if
they need to be
changed also. Otherwise this same issue will undoubtedly come up in the
future.

The decision process I would use is:

1. Does the term NEED to be changed? Is it confusing, is there a trademark
issue (DB2), etc.

2. If the answer to #1 is 'no' then leave it alone.

3. If the answer to #1 is 'yes'  then examine each and every reference to
the term and
    change it as needed.



Mime
View raw message