db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "RPost" <rp0...@pacbell.net>
Subject Re: [PATCH] Change all Identifier Limitations to 128
Date Thu, 16 Dec 2004 17:18:41 GMT
I'm all for changing terms if it makes sense but if a term is going to
be changed it should be changed globally. Let's do it right the first time.

A quick search of the 'engine' tree with Windows Explorer shows

1. 30 *.java files with the string 'DB2Limit' in them.
2. an additional 74 files with the string 'DB2' in them.
3. 223 files with the string 'cloudscape' in them.

These terms also exist in large numbers in the other branches of the source.

A quick look at several of the files with 'DB2Limit' in them shows that
they will probably all need to be changed.

Maybe we can add terms like 'DB2', 'cloudscape', etc. to a todo list of
candidates for cleanup.

When a developer modifies a source file to fix a bug or add functionality
they could cleanup these items.

----- Original Message ----- 
From: "Lance J. Andersen" <Lance.Andersen@sun.com>
To: "Philipp Hug" <philipp@hug.cx>
Cc: "Derby Development" <derby-dev@db.apache.org>
Sent: Thursday, December 16, 2004 8:32 AM
Subject: Re: [PATCH] Change all Identifier Limitations to 128


> Hi Phillipp,
>
> Unless i misread the diffs, it looks like there are still some
> references to DB2Limit and constants with DB2_ as the prefix.
>
> Here are a couple of examples.
>
> >Index: java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java
> >===================================================================
> >--- java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java
(revision 111709)
> >+++ java/engine/org/apache/derby/impl/sql/compile/CreateAliasNode.java
(working copy)
> >@@ -28,7 +28,7 @@
> > import org.apache.derby.iapi.sql.compile.C_NodeTypes;
> >
> > import org.apache.derby.iapi.reference.SQLState;
> >-import org.apache.derby.iapi.reference.DB2Limit;
> >+import org.apache.derby.iapi.reference.DerbyLimit;
> >
> > import org.apache.derby.iapi.sql.ResultSet;
> > import org.apache.derby.iapi.sql.execute.ConstantAction;
> >@@ -126,9 +126,9 @@
> > TypeDescriptor[] types = null;
> > int[] modes = null;
> >
> >- if (paramCount > DB2Limit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE)
> >+ if (paramCount > DerbyLimit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE)
> > throw
StandardException.newException(SQLState.LANG_TOO_MANY_PARAMETERS_FOR_STORED_
PROC,
> >- String.valueOf(DB2Limit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE), aliasName,
String.valueOf(paramCount));
> >+ String.valueOf(DerbyLimit.DB2_MAX_PARAMS_IN_STORED_PROCEDURE),
aliasName, String.valueOf(paramCount));
> >
> >
>
> Is there a reason that this is still DB2_MAX_PARAMS?
>
> > /* identifier() used to be columnName() */
> >- //unqualified column names are limited to 30 characters
> >- columnName = identifier(DB2Limit.DB2_MAX_IDENTIFIER_LENGTH30, true)
> >+ //unqualified column names are limited to 128 characters
> >+ columnName = identifier(DB2Limit.DB2_MAX_IDENTIFIER_LENGTH128, true)
> > ( typeDescriptor = dataTypeDDL()
> > )
> > [ defaultNode = defaultAndConstraints(typeDescriptor, tableElementList,
columnName, autoIncrementInfo) ]
> >@@ -4115,7 +4115,7 @@
> > //limit the qualifiedId to the id length limit passed to this method
> > checkIdentifierLengthLimit(qualifiedId, id_length_limit);
> > if (schemaName != null)
> >- checkIdentifierLengthLimit(schemaName,
DB2Limit.DB2_MAX_IDENTIFIER_LENGTH30);
> >+ checkIdentifierLengthLimit(schemaName,
DB2Limit.DB2_MAX_IDENTIFIER_LENGTH128);
> >
> >
>
> DB2Limit is still the class name
>
>
> Regards
> Lance


Mime
View raw message