Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Derby Development" <derby-dev@db.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Date: Mon, 22 Nov 2004 09:23:12 +0530
From: Shreyas Kaushik <Shreyas.Kaushik@Sun.COM>
Subject: Re: [PATCH] For the open issue with key Derby-33
In-reply-to: <419E2B42.7060209@debrunners.com>
To: Daniel John Debrunner <djd@debrunners.com>
Cc: Derby Development <derby-dev@db.apache.org>
Reply-to: Shreyas.Kaushik@Sun.COM
Message-id: <41A162A8.3050504@Sun.COM>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7BIT
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20040414
References: <419DDC51.80704@Sun.COM> <419E2B42.7060209@debrunners.com>

Hi Dan,

  Just to clarify the fix should take care of the conditions the
following way :

null Map      --> throw a SQLException
empty Map     --> no-op
non-empty Map --> throw notImplemented.

Please confirm. I will fix it accordingly.

thanks
Shreyas

Daniel John Debrunner wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Shreyas Kaushik wrote:
> 
> 
>>Hi,
>>
>>  I am attaching the patch to fix the Open issue with key *Derby-33*
>>having the description *Connection.setTypeMap throws unimplemented
>>exception with empty map*.
>>
>> This patch takes care of proper handling of the empty map condition.
>>
>> I have also updated JIRA with my comments on 18-Nov-2004.
>>
>>thanks
>>Shreyas
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java
>>===================================================================
>>--- java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java
> 
> (revision 105806)
> 
>>+++ java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java
> 
> (working copy)
> 
>>@@ -109,7 +109,10 @@
>>      * @exception SQLException Feature not implemented for now.
>> 	 */
>>     public void setTypeMap(java.util.Map map) throws SQLException {
>>-		throw Util.notImplemented();
>>+        if((map != null)) {
>>+             if(!(map.isEmpty()))
>>+                 throw Util.notImplemented();
>>+        }
>>     }
>>
>> 	/*
> 
> 
> 
> Thanks for the patch, though I think the fix does not handle null
> correctly. Passing in null should throw an exception, not be silently
> ignored.
> 
> See this message I sent yesterday.
> 
> http://nagoya.apache.org/eyebrowse/ReadMsg?listName=derby-dev@db.apache.org&msgNo=950
> 
> Also I think this is a partial fix to Derby 33. Derby should be
> consistent in empty map (and null) handling in other JDBC methods that
> take a type Map (ie. getObject in ResultSet and CallableStatement).
> 
> Dan.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.5 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFBnitCIv0S4qsbfuQRApHlAJ4zg43NoYl+7PBHZCv7Z4fKcfy0TQCfWtUY
> 2+At27jA5xEDXOd043EPaJM=
> =GsfY
> -----END PGP SIGNATURE-----
>