Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 67162 invoked from network); 19 Nov 2004 11:44:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 19 Nov 2004 11:44:32 -0000 Received: (qmail 89853 invoked by uid 500); 19 Nov 2004 11:44:21 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 89744 invoked by uid 500); 19 Nov 2004 11:44:20 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: List-Id: Reply-To: "Derby Development" Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 89700 invoked by uid 99); 19 Nov 2004 11:44:20 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [192.18.98.36] (HELO brmea-mail-4.sun.com) (192.18.98.36) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 19 Nov 2004 03:44:16 -0800 Received: from phys-biff-1 ([129.158.227.36]) by brmea-mail-4.sun.com (8.12.10/8.12.9) with ESMTP id iAJBiBun007203 for ; Fri, 19 Nov 2004 04:44:12 -0700 (MST) Received: from conversion-daemon.biff-mail1.india.sun.com by biff-mail1.india.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) id <0I7F00D01CGZNY@biff-mail1.india.sun.com> (original mail from Shreyas.Kaushik@Sun.COM) for derby-dev@db.apache.org; Fri, 19 Nov 2004 17:14:11 +0530 (IST) Received: from Sun.COM (lilly.India.Sun.COM [129.158.229.246]) by biff-mail1.india.sun.com (iPlanet Messaging Server 5.2 HotFix 1.24 (built Dec 19 2003)) with ESMTP id <0I7F00HB1CLMP4@biff-mail1.india.sun.com> for derby-dev@db.apache.org; Fri, 19 Nov 2004 17:14:10 +0530 (IST) Date: Fri, 19 Nov 2004 17:13:13 +0530 From: Shreyas Kaushik Subject: [PATCH] For the open issue with key Derby-33 To: Derby Development Reply-to: Shreyas.Kaushik@Sun.COM Message-id: <419DDC51.80704@Sun.COM> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_fFd9WQmbVVtLdF6yOFGf8w)" X-Accept-Language: en-us, en User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20040414 X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N This is a multi-part message in MIME format. --Boundary_(ID_fFd9WQmbVVtLdF6yOFGf8w) Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Hi, I am attaching the patch to fix the Open issue with key *Derby-33* having the description *Connection.setTypeMap throws unimplemented exception with empty map*. This patch takes care of proper handling of the empty map condition. I have also updated JIRA with my comments on 18-Nov-2004. thanks Shreyas --Boundary_(ID_fFd9WQmbVVtLdF6yOFGf8w) Content-type: text/plain; name=setTypeMap.patch Content-transfer-encoding: 7BIT Content-disposition: inline; filename=setTypeMap.patch Index: java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java =================================================================== --- java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java (revision 105806) +++ java/engine/org/apache/derby/impl/jdbc/EmbedConnection20.java (working copy) @@ -109,7 +109,10 @@ * @exception SQLException Feature not implemented for now. */ public void setTypeMap(java.util.Map map) throws SQLException { - throw Util.notImplemented(); + if((map != null)) { + if(!(map.isEmpty())) + throw Util.notImplemented(); + } } /* --Boundary_(ID_fFd9WQmbVVtLdF6yOFGf8w)--