db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@debrunners.com>
Subject Re: Should patches also update functional tests?
Date Wed, 24 Nov 2004 16:14:22 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


I would like to add that if you submit a patch it would be very useful
for the committers if you stated which (if any) tests suites on which
jvm(s) you ran (with no failures :-). Obviously you can submit a patch
without running tests, but it may deley the commit of that patch, until
a committer has run what they deem to be sufficient tests.

As for test cases with patches, I would strongly encourage the addition
of test cases, typically added to existing tests. This will get easier
once IBM has contributed the remaining tests for Cloudscape/Derby. I
think also a committer has the right to ask a patch submitter to
demonstrate that a patch does indeed solve the problem, if it is not
obvious from the fix. The easiest way to do this would be a test case.

Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBpLNeIv0S4qsbfuQRAgZKAKCU0fEMPJbUYwwGiDeCg6Hx5+3ybgCg0L8y
NGtCrVjXlOKOLhtsVOGZ5NQ=
=HN9P
-----END PGP SIGNATURE-----


Mime
View raw message