db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Satheesh Bandaram <sathe...@Sourcery.Org>
Subject Should patches also update functional tests?
Date Tue, 23 Nov 2004 20:16:07 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
-----BEGIN PGP SIGNED MESSAGE----- <br>
Hash: SHA1 <br>
&nbsp;<br>
I would like to seek suggestions or comments regarding submitting
patches with appropriate test changes. Since Derby now has functional
tests, should we suggest or even require patches to be submitted along
with a test case added? This will only apply if a test case is
available and doesn't require undue amount of time and resources to
test the patch.<br>
<br>
Obvious advantages are:<br>
<br>
&nbsp;&nbsp; 1. We can be sure we are indeed addressing the problem. Unless
committers write a test case based on the code changed, we may not know
for sure we did fix the problem correctly.<br>
&nbsp;&nbsp; 2. Can prevent future regressions in the code, where the same defect
is reintroduced because of another patch or enhancement.<br>
&nbsp;&nbsp; 3. Strengthens Derby funtional test suites and test coverage.<br>
<br>
This may introduce additional burden on patch submissions, hence, we
could make this voluntary to start with. How do other Apache projects
handle this?<br>
<br>
Satheesh<br>
-----BEGIN PGP SIGNATURE----- <br>
Version: GnuPG v1.2.5 (MingW32) <br>
Comment: Using GnuPG with Thunderbird - <a class="moz-txt-link-freetext" href="http://enigmail.mozdev.org">http://enigmail.mozdev.org</a>
<br>
&nbsp;<br>
iD8DBQFBo5qHENVNIY6DZ7ERAiXKAJ4u2LqRt6DQRmyD9tnVrUKcnU+9zACfcqRc <br>
t9KHweaziJ934nzRpqTLZvQ= <br>
=+2mR <br>
-----END PGP SIGNATURE----- <br>
<br>
</body>
</html>

Mime
View raw message