db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myrnap <my...@Golux.Com>
Subject [PATCH] retrieveMessages... true by default in ij
Date Tue, 14 Sep 2004 01:07:26 GMT
Hi,

Currently, the networkserver-related ij property 
retrieveMessagesFromServerOnGetMessage is false by default.
The disadvantage of setting this property to true is that performance 
might be slower, the advantage of setting it is that you get actual 
message text.
It would be nice if this could be true by default (only relevant if the 
driver is the universal driver).
It seems to me maximum performance may be less important with ij (as 
opposed to access in an application) than getting helpful messages. And 
if it is important, the property can easily be set false when starting 
ij, by using the property: ij.retrieveMessagesFromServerOnGetMessage=false

Making the default value true also allows me to take out the references 
to "framework", which is a property used in the (subset of IBM 
Cloudscape) functionTests for Derby that I'm working on. Taking the 
reference out makes a cleaner separation between product  & test.

Once this is agreed on, documentation should also change.

svn diff:
Index: java/tools/org/apache/derby/impl/tools/ij/util.java
===================================================================
--- java/tools/org/apache/derby/impl/tools/ij/util.java (revision 45860)
+++ java/tools/org/apache/derby/impl/tools/ij/util.java (working copy)
@@ -400,7 +400,7 @@
            String password = util.getSystemProperty("ij.password");

            // Update connInfo for ij system properties and
-           // framework network server
+           // get text for messages for network server

            connInfo = updateConnInfo(user, password,connInfo);

@@ -445,16 +445,10 @@

        public static Properties updateConnInfo(String user, String 
password, Properties connInfo)
        {
-               String framework = util.getSystemProperty("framework");
                String ijGetMessages = 
util.getSystemProperty("ij.retrieveMessagesFromServerOnGetMessage");
-               boolean retrieveMessages = false;
+               // For JCC default to retrieve messages
+               boolean retrieveMessages = true;

-
-               // For JCC make sure we set it to retrieve messages
-               if (framework != null  && ((framework.equals("DB2jNet")
-                                                                       
|| framework.equals("DB2jcc"))))
-                       retrieveMessages = true;
-
                if (ijGetMessages != null)
                {
                        if (ijGetMessages.equals("false"))


-------------------
Myrna van Lunteren
- IBM -

Mime
View raw message