db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian W. Fitzpatrick" <f...@red-bean.com>
Subject Re: [PATCH] Optimization of org.apache.derby.impl.services.uuid.BasicUUID.toByteArray()
Date Fri, 03 Sep 2004 06:04:40 GMT

On Sep 3, 2004, at 12:19 AM, Jan Hlavatý wrote:
> Jan Hlavatý wrote:
>> Ah! These tildes seem to have been added when I sent the mail...
>
> Is this better?

Not really.  :-)  See below.

> Index: java/engine/org/apache/derby/impl/services/uuid/BasicUUID.java
> ===================================================================
> - ---  
> java/engine/org/apache/derby/impl/services/uuid/BasicUUID.java	 
> (revision 37291)
> +++  
> java/engine/org/apache/derby/impl/services/uuid/BasicUUID.java	 
> (working copy)
> @@ -279,26 +279,26 @@
>  		byte[] result = new byte[16];
>
>  		int lsequence = sequence;
> - -		result[0] = (byte)((lsequence & 0xff000000) >>> 24);
> - -		result[1] = (byte)((lsequence & 0x00ff0000) >>> 16);
> - -		result[2] = (byte)((lsequence & 0x0000ff00) >>> 8);
> - -		result[3] = (byte) (lsequence & 0x000000ff);
> +		result[0] = (byte)(lsequence >>> 24);
> +		result[1] = (byte)(lsequence >>> 16);
> +		result[2] = (byte)(lsequence >>> 8);
> +		result[3] = (byte)lsequence;

Your mailer still seems to be munging the patch--it's prefixing any  
line that starts with a '-' with '- '.

I strongly recommend attaching the patch as text/plain.

-Fitz


Mime
View raw message