db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mi...@apache.org
Subject svn commit: r1641753 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java
Date Wed, 26 Nov 2014 02:48:06 GMT
Author: mikem
Date: Wed Nov 26 02:48:06 2014
New Revision: 1641753

URL: http://svn.apache.org/r1641753
Log:
DERBY-6774 org.apache.derbyTesting.functionTests.tests.lang.AlterTableTest.testAddIdentityColumn
failed with assert in nightlys

Temporarily removing assert that is failing, looks like code should handle
the condition anyway.  Will renable after figuring out what is going on, 
hoping this will allow for clean runs from others while I work on this issue.
My current theory is that there is a long time problem with alter table
and the conglomerate cache that has been uncovered by this relatively new
test and the new background work introduced by DERBY-4057.


Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java?rev=1641753&r1=1641752&r2=1641753&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/store/access/heap/Heap.java Wed
Nov 26 02:48:06 2014
@@ -416,6 +416,23 @@ public class Heap 
                     ContainerHandle.MODE_FORUPDATE | 
                         (isTemporary() ? ContainerHandle.MODE_TEMP_IS_KEPT : 0));
 
+            // DERBY-6774 - temp disabling this ASSERT while working on
+            // why it is firing in trunk.   The hope is that trunk tests
+            // will pass for others while I work on fixing DERBY-6774.
+            //
+            // The code always adds the column after the last field even
+            // if there is a mismatch with what is requested.  The store
+            // only supports adding a column at the end anyway.
+            //
+            // I believe the issue is some sort of timing with background
+            // threads and alter table and the conglomerate cache.  The
+            // conglomerate cache was created assuming the data was static,
+            // but in the case of alter table add and drop column this is
+            // not true.  There are some attempts in the access layer to
+            // invalidate the cache after an abort of a alter table, but
+            // I think there is still a race condition.
+
+            /*
             if (column_id != format_ids.length)
             {
                 if (SanityManager.DEBUG)
@@ -430,6 +447,7 @@ public class Heap 
                         new Long(column_id), 
                         new Long(this.format_ids.length)));
             }
+            */
 
             // create a new array, and copy old values to it.
             int[] old_format_ids = format_ids;



Mime
View raw message