db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kahat...@apache.org
Subject svn commit: r1620828 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java
Date Wed, 27 Aug 2014 09:16:03 GMT
Author: kahatlen
Date: Wed Aug 27 09:16:03 2014
New Revision: 1620828

URL: http://svn.apache.org/r1620828
Log:
DERBY-6716: Minor fixes in SystemPrivilegesPermissionTest

Fix typos to improve test coverage:

- check both "p1 implies p2" and "p2 implies p1" in
  assertEquivalentPermissions(), instead of checking "p1 implies p2"
  twice.

- remove a stray if statement that disables an assert in situations
  where it's expected to succeed.

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java?rev=1620828&r1=1620827&r2=1620828&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/unitTests/junit/SystemPrivilegesPermissionTest.java
Wed Aug 27 09:16:03 2014
@@ -379,7 +379,6 @@ public class SystemPrivilegesPermissionT
                             f = a;
                             s = oa;
                         }
-                        if (oa < a)
                         assertEquals(validActions[f] + "," + validActions[s],
                                 p.getActions());
                     }
@@ -1071,7 +1070,7 @@ public class SystemPrivilegesPermissionT
         assertEquals(p1.hashCode(), p2.hashCode());
         
         assertTrue(p1.implies(p2));
-        assertTrue(p1.implies(p2));
+        assertTrue(p2.implies(p1));
     }
     
     /**



Mime
View raw message