db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r1469197 - /db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java
Date Thu, 18 Apr 2013 07:18:53 GMT
Author: dag
Date: Thu Apr 18 07:18:53 2013
New Revision: 1469197

URL: http://svn.apache.org/r1469197
Log:
DERBY-6128 Examine Derby classes to determine if we need to add serialVersionUID to any of
them 

Patch derby-6128-ecpds40.diff. 

Added comment to EmbeddedConnectionPoolDataSource40:

// This explicit UID was missing for releases 10.10.1.1 and lower.
// The default changed between 10.7 and 10.8,
// so even with this explicit UID in place, serialized data sources
// created with 10.7 or older would not be readable.
// The default UID in 10.7 was -2155993232624542236.
// This was not caught by the serialization tests at the time since
// the "40"-suffixed data sources were not tested back then, cf DERBY-5955
// http://svn.apache.org/viewvc?view=revision&revision=1438035 .



Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java?rev=1469197&r1=1469196&r2=1469197&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedConnectionPoolDataSource40.java
Thu Apr 18 07:18:53 2013
@@ -60,6 +60,15 @@ public class EmbeddedConnectionPoolDataS
     implements javax.sql.ConnectionPoolDataSource // compile-time check for
                                                   // 4.1 extension
 {
+    // This explicit UID was missing for releases 10.10.1.1 and lower.
+    // The default changed between 10.7 and 10.8,
+    // so even with this explicit UID in place, serialized data sources
+    // created with 10.7 or older would not be readable.
+    // The default UID in 10.7 was -2155993232624542236.
+    // This was not caught by the serialization tests at the time since
+    // the "40"-suffixed data sources were not tested back then, cf DERBY-5955
+    // http://svn.apache.org/viewvc?view=revision&revision=1438035 .
+    private static final long serialVersionUID = -4368824293743156916L;
     
     ////////////////////////////////////////////////////////////////////
     //



Mime
View raw message