db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krist...@apache.org
Subject svn commit: r1442483 - in /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests: Changes10_9.java helpers/DisposableIndexStatistics.java
Date Tue, 05 Feb 2013 07:11:05 GMT
Author: kristwaa
Date: Tue Feb  5 07:11:04 2013
New Revision: 1442483

URL: http://svn.apache.org/viewvc?rev=1442483&view=rev
Log:
DERBY-6064: Failures in upgradeTests.Changes10_9 related to index cardinality statistics

Improved comment(s) and fixed a typo.

Patch file: derby-6064-2a-fix_comment.diff

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/helpers/DisposableIndexStatistics.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java?rev=1442483&r1=1442482&r2=1442483&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_9.java
Tue Feb  5 07:11:04 2013
@@ -999,9 +999,10 @@ public class Changes10_9 extends Upgrade
             case PH_CREATE:
             {
                 dis.createAndPopulateTables();
-                // We expect that the maximum number of statistics have been
-                // created here, since we're using an older version of Derby
-                // that contained a bug and lacked the latest optimizations.
+                // The expected number of statistics entries depends on the
+                // version of Derby used to create the database. Some older
+                // versions of Derby contained a bug and lacked optimizations,
+                // causing the number of statistics entries to increase.
                 dis.assertStatsCount(false);
                 break;
             }

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/helpers/DisposableIndexStatistics.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/helpers/DisposableIndexStatistics.java?rev=1442483&r1=1442482&r2=1442483&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/helpers/DisposableIndexStatistics.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/helpers/DisposableIndexStatistics.java
Tue Feb  5 07:11:04 2013
@@ -218,11 +218,11 @@ public class DisposableIndexStatistics {
             expected -= getNumDisposableStats();
         } else if (!hasDerby5681Bug(oldVersion)) {
             // Here we correct for the orphaned statistics entry, but not for
-            // entires that are considered extraneous by newer releases (for
+            // entries that are considered extraneous by newer releases (for
             // instance statistics for single column unique indexes).
             expected--;
         }
-        ArrayList entries = new ArrayList();
+        ArrayList entries = new ArrayList(); // used for reporting only
         int found = getAllRelevantStats(entries);
         if (found != expected) {
             Assert.assertEquals(



Mime
View raw message