db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bpendle...@apache.org
Subject svn commit: r1356065 - /db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java
Date Mon, 02 Jul 2012 03:49:22 GMT
Author: bpendleton
Date: Mon Jul  2 03:49:22 2012
New Revision: 1356065

URL: http://svn.apache.org/viewvc?rev=1356065&view=rev
Log:
DERBY-5827: Remove unused methods in NetStatementReply class

This patch was contributed by Mohamed Nufail (nufail56 at gmail dot com)

This change removes several unused methods from the NetStatementReply
class. Code inspection of the NetStatementReply class reveals that
the following methods are not used at all:

parseQRYPRCTYP()
parseSQLCSRHLD()
parseQRYATTSCR()
parseQRYATTSET()
parseQRYATTSNS()
parseQRYATTUPD() 

Modified:
    db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java

Modified: db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java?rev=1356065&r1=1356064&r2=1356065&view=diff
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/net/NetStatementReply.java Mon
Jul  2 03:49:22 2012
@@ -1648,17 +1648,6 @@ public class NetStatementReply extends N
         return section;
     }
 
-    // Query Protocol type specifies the type of query protocol
-    // the target SQLAM uses.
-    protected int parseQRYPRCTYP() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.QRYPRCTYP);
-        int qryprctyp = parseCODPNTDR();
-        if ((qryprctyp != CodePoint.FIXROWPRC) && (qryprctyp != CodePoint.LMTBLKPRC))
{
-            doValnsprmSemantics(CodePoint.QRYPRCTYP, qryprctyp);
-        }
-        return qryprctyp;
-    }
-
     protected int parseFastQRYPRCTYP() throws DisconnectException {
         matchCodePoint(CodePoint.QRYPRCTYP);
         int qryprctyp = readFastUnsignedShort();
@@ -1668,23 +1657,6 @@ public class NetStatementReply extends N
         return qryprctyp;
     }
 
-    // hold cursor position state indicates whether the requester specified
-    // the HOLD option on the SQL DECLARE CURSOR statement.  When the HOLD
-    // option is specified, the cursor is not closed upon execution of a
-    // commit operation.
-    // The value TRUE indicates that the requester specifies the HOLD
-    // operation.  The value FALSSE indicates that the requeter is not
-    // specifying the HOLD option.
-    protected int parseSQLCSRHLD() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.SQLCSRHLD);
-        int sqlcsrhld = readUnsignedByte();
-        // 0xF0 is false (default), 0xF1 is true  // use constants in if
-        if ((sqlcsrhld != 0xF0) && (sqlcsrhld != 0xF1)) {
-            doValnsprmSemantics(CodePoint.SQLCSRHLD, sqlcsrhld);
-        }
-        return sqlcsrhld;
-    }
-
     protected int parseFastSQLCSRHLD() throws DisconnectException {
         matchCodePoint(CodePoint.SQLCSRHLD);
         int sqlcsrhld = readFastUnsignedByte();
@@ -1695,17 +1667,6 @@ public class NetStatementReply extends N
         return sqlcsrhld;
     }
 
-    // Query Attribute for Scrollability indicates whether
-    // a cursor is scrollable or non-scrollable
-    protected int parseQRYATTSCR() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.QRYATTSCR);
-        int qryattscr = readUnsignedByte();  // use constants in if
-        if ((qryattscr != 0xF0) && (qryattscr != 0xF1)) {
-            doValnsprmSemantics(CodePoint.QRYATTSCR, qryattscr);
-        }
-        return qryattscr;
-    }
-
     protected int parseFastQRYATTSCR() throws DisconnectException {
         matchCodePoint(CodePoint.QRYATTSCR);
         int qryattscr = readFastUnsignedByte();  // use constants in if
@@ -1715,16 +1676,6 @@ public class NetStatementReply extends N
         return qryattscr;
     }
 
-    // enabled for rowset positioning.
-    protected int parseQRYATTSET() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.QRYATTSET);
-        int qryattset = readUnsignedByte();  // use constants in if
-        if ((qryattset != 0xF0) && (qryattset != 0xF1)) {
-            doValnsprmSemantics(CodePoint.QRYATTSET, qryattset);
-        }
-        return qryattset;
-    }
-
     protected int parseFastQRYATTSET() throws DisconnectException {
         matchCodePoint(CodePoint.QRYATTSET);
         int qryattset = readFastUnsignedByte();  // use constants in if
@@ -1734,23 +1685,6 @@ public class NetStatementReply extends N
         return qryattset;
     }
 
-    // Query attribute for Sensitivity indicats the sensitivity
-    // of an opened cursor to changes made to the underlying
-    // base table.
-    protected int parseQRYATTSNS() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.QRYATTSNS);
-        int qryattsns = readUnsignedByte();
-        switch (qryattsns) {
-        case CodePoint.QRYUNK:
-        case CodePoint.QRYINS:
-            break;
-        default:
-            doValnsprmSemantics(CodePoint.QRYATTSNS, qryattsns);
-            break;
-        }
-        return qryattsns;
-    }
-
     protected int parseFastQRYATTSNS() throws DisconnectException {
         matchCodePoint(CodePoint.QRYATTSNS);
         int qryattsns = readFastUnsignedByte();
@@ -1766,23 +1700,6 @@ public class NetStatementReply extends N
         return qryattsns;
     }
 
-    // Query Attribute for Updatability indicates the updatability
-    // of an opened cursor.
-    protected int parseQRYATTUPD() throws DisconnectException {
-        parseLengthAndMatchCodePoint(CodePoint.QRYATTUPD);
-        int qryattupd = readUnsignedByte();
-        switch (qryattupd) {
-        case CodePoint.QRYUNK:
-        case CodePoint.QRYRDO:
-        case CodePoint.QRYUPD:
-            break;
-        default:
-            doValnsprmSemantics(CodePoint.QRYATTUPD, qryattupd);
-            break;
-        }
-        return qryattupd;
-    }
-
     protected int parseFastQRYATTUPD() throws DisconnectException {
         matchCodePoint(CodePoint.QRYATTUPD);
         int qryattupd = readFastUnsignedByte();



Mime
View raw message