Return-Path: X-Original-To: apmail-db-derby-commits-archive@www.apache.org Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFBDACF0E for ; Mon, 7 May 2012 09:06:13 +0000 (UTC) Received: (qmail 48373 invoked by uid 500); 7 May 2012 09:06:13 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 48329 invoked by uid 500); 7 May 2012 09:06:13 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 48313 invoked by uid 99); 7 May 2012 09:06:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2012 09:06:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2012 09:06:10 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4D62D2388847; Mon, 7 May 2012 09:05:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1334929 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java Date: Mon, 07 May 2012 09:05:49 -0000 To: derby-commits@db.apache.org From: kahatlen@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120507090549.4D62D2388847@eris.apache.org> Author: kahatlen Date: Mon May 7 09:05:48 2012 New Revision: 1334929 URL: http://svn.apache.org/viewvc?rev=1334929&view=rev Log: Remove comment that referred to old code. The code was changed to use Calendar.setTimeInMillis() in DERBY-2397, so there is no longer a need for a comment explaining why setTimeInMillis() is not used. Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java?rev=1334929&r1=1334928&r2=1334929&view=diff ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java Mon May 7 09:05:48 2012 @@ -10160,10 +10160,6 @@ public final class DataDictionaryImpl */ public String getSystemSQLName() { - //note that we are using Date class to change the Calendar object time rather than Calendar.setTimeInMills. - //This is because of java bug 4243802. setTimeInMillis and getTimeInMillis were protected prior to jdk14 - //But since we still support jdk13, we can't rely on these methods being public starting jdk14. - //Because of that, we are using Date to do all the time manipulations on the Calendar object StringBuffer generatedSystemSQLName = new StringBuffer("SQL"); synchronized (this) { //get the current timestamp