db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myrn...@apache.org
Subject svn commit: r1335820 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java
Date Tue, 08 May 2012 23:16:53 GMT
Author: myrnavl
Date: Tue May  8 23:16:53 2012
New Revision: 1335820

URL: http://svn.apache.org/viewvc?rev=1335820&view=rev
Log:
DERBY-5686; multiple intermittent errors in nightly tests during DriverMgrAuthenticationTest
test. reason: An SQL data change is not permitted for a read-only connection, user or database.
  adding a finally block to increase the attempt count always. 

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java?rev=1335820&r1=1335819&r2=1335820&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java Tue
May  8 23:16:53 2012
@@ -1523,7 +1523,6 @@ public abstract class BaseJDBCTestCase
             }
             try {
                 fl = PrivilegedFileOpsForTests.persistentRecursiveDelete(dir);
-                attempts++;
             } catch (FileNotFoundException fnfe) {
                 if (attempts == 0) {
                     fail("directory doesn't exist: " +
@@ -1536,6 +1535,7 @@ public abstract class BaseJDBCTestCase
                             "external or concurrent delete?");
                 }
             }
+            finally { attempts++; }
             if (fl.length == 0) {
                 return;
             } else {



Mime
View raw message