db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kahat...@apache.org
Subject svn commit: r1334929 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
Date Mon, 07 May 2012 09:05:49 GMT
Author: kahatlen
Date: Mon May  7 09:05:48 2012
New Revision: 1334929

URL: http://svn.apache.org/viewvc?rev=1334929&view=rev
Remove comment that referred to old code.

The code was changed to use Calendar.setTimeInMillis() in DERBY-2397, so
there is no longer a need for a comment explaining why setTimeInMillis()
is not used.


Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java?rev=1334929&r1=1334928&r2=1334929&view=diff
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
Mon May  7 09:05:48 2012
@@ -10160,10 +10160,6 @@ public final class	DataDictionaryImpl
 	public String getSystemSQLName()
-		//note that we are using Date class to change the Calendar object time rather than Calendar.setTimeInMills.
-		//This is because of java bug 4243802. setTimeInMillis and getTimeInMillis were protected
prior to jdk14
-		//But since we still support jdk13, we can't rely on these methods being public starting
-		//Because of that, we are using Date to do all the time manipulations on the Calendar object

 		StringBuffer generatedSystemSQLName = new StringBuffer("SQL");
 			synchronized (this) {
 				//get the current timestamp

View raw message