db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krist...@apache.org
Subject svn commit: r1334873 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
Date Mon, 07 May 2012 05:00:46 GMT
Author: kristwaa
Date: Mon May  7 05:00:46 2012
New Revision: 1334873

URL: http://svn.apache.org/viewvc?rev=1334873&view=rev
Log:
Removed inaccurate comment. While integer reads/writes are atomic, we must also
use volatile for this code to be thread safe. We are, and that means we are 
using synchronization.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java?rev=1334873&r1=1334872&r2=1334873&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
Mon May  7 05:00:46 2012
@@ -1367,21 +1367,11 @@ public final class	DataDictionaryImpl
 		}
 	}
 
-	/*
-	** SYNCHRONIZATION: no synchronization
-	** necessary since integer reads/writes
-	** are atomic
-	*/
 	public int getCacheMode()
 	{
 		return cacheMode;
 	}
 
-	/*
-	** SYNCHRONIZATION: no synchronization
-	** necessary since integer reads/writes
-	** are atomic
-	*/
 	private void setCacheMode(int newMode)
 	{
 		cacheMode = newMode;



Mime
View raw message