db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krist...@apache.org
Subject svn commit: r1307392 - in /db/derby/code/trunk/java/engine/org/apache/derby: iapi/reference/Property.java impl/services/daemon/IndexStatisticsDaemonImpl.java impl/sql/catalog/DataDictionaryImpl.java
Date Fri, 30 Mar 2012 13:05:50 GMT
Author: kristwaa
Date: Fri Mar 30 13:05:49 2012
New Revision: 1307392

URL: http://svn.apache.org/viewvc?rev=1307392&view=rev
Log:
DERBY-5083: Document automatic update and creation of index cardinality statistics (istat)

Fixed comment, which used an incorrect value for the trace property.
Removed two TODOs.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Property.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Property.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Property.java?rev=1307392&r1=1307391&r2=1307392&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Property.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Property.java Fri Mar
30 13:05:49 2012
@@ -685,7 +685,7 @@ public interface Property { 
 
     /**
      * Tells if more detailed activities related to automatic index statistics
-     * update should be traced. Accepted values are: *none*, stdout, log, both
+     * update should be traced. Accepted values are: *off*, stdout, log, both
      */
     String STORAGE_AUTO_INDEX_STATS_TRACING = "derby.storage.indexStats.trace";
 

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java?rev=1307392&r1=1307391&r2=1307392&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java
Fri Mar 30 13:05:49 2012
@@ -121,7 +121,6 @@ public class IndexStatisticsDaemonImpl
     private final HeaderPrintWriter logStream;
     /** Tells if logging is enabled. */
     private final boolean doLog;
-    // TODO: Consider removing the trace functionality after testing/tuning.
     /** Tells if tracing is enabled. */
     private final boolean doTrace;
     /** Tells if traces are written to the Derby log file. */

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java?rev=1307392&r1=1307391&r2=1307392&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
Fri Mar 30 13:05:49 2012
@@ -855,7 +855,6 @@ public final class	DataDictionaryImpl
                     indexStatsUpdateLogging = Boolean.valueOf(
                             dbEnableIndexStatsLogging).booleanValue();
                 }
-                // TODO: This property may go away in production code.
                 String dbEnableIndexStatsTracing =
                         PropertyUtil.getDatabaseProperty(bootingTC,
                             Property.STORAGE_AUTO_INDEX_STATS_TRACING);



Mime
View raw message