db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kahat...@apache.org
Subject svn commit: r1183671 - in /db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest: init/DbSetup.java init/Initializer.java utils/DbUtil.java
Date Sat, 15 Oct 2011 16:58:00 GMT
Author: kahatlen
Date: Sat Oct 15 16:58:00 2011
New Revision: 1183671

URL: http://svn.apache.org/viewvc?rev=1183671&view=rev
Log:
DERBY-5465: Broken null checks in NsTest

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/utils/DbUtil.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java?rev=1183671&r1=1183670&r2=1183671&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java
Sat Oct 15 16:58:00 2011
@@ -171,7 +171,7 @@ public class DbSetup {
 						+ " SQLSTATE: " + m);
 			}
 		}
-		if (e.getMessage().equals(null)) {
+		if (e.getMessage() == null) {
 			System.out.println("NULL error message detected");
 			System.out.println("Here is the NULL exection - " + e.toString());
 			System.out.println("Stack trace of the NULL exception - ");

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java?rev=1183671&r1=1183670&r2=1183671&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/init/Initializer.java
Sat Oct 15 16:58:00 2011
@@ -136,7 +136,7 @@ public class Initializer {
 						+ " SQLSTATE: " + m);
 			}
 		}
-		if (e.getMessage().equals(null)) {
+		if (e.getMessage() == null) {
 			e.printStackTrace(System.out);
 		}
 		System.out.println("During - " + where

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/utils/DbUtil.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/utils/DbUtil.java?rev=1183671&r1=1183670&r2=1183671&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/utils/DbUtil.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/nstest/utils/DbUtil.java
Sat Oct 15 16:58:00 2011
@@ -542,7 +542,7 @@ public class DbUtil {
 						+ " " + se.getErrorCode());
 			}
 		}
-		if (e.getMessage().equals(null)) {
+		if (e.getMessage() == null) {
 			System.out.println(getThreadName()
 					+ " dbUtil --> NULL error message detected");
 			System.out



Mime
View raw message