From derby-commits-return-13227-apmail-db-derby-commits-archive=db.apache.org@db.apache.org Fri Oct 08 19:19:56 2010
Return-Path: <derby-commits-return-13227-apmail-db-derby-commits-archive=db.apache.org@db.apache.org>
Delivered-To: apmail-db-derby-commits-archive@www.apache.org
Received: (qmail 84622 invoked from network); 8 Oct 2010 19:19:56 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 8 Oct 2010 19:19:56 -0000
Received: (qmail 15343 invoked by uid 500); 8 Oct 2010 19:19:56 -0000
Delivered-To: apmail-db-derby-commits-archive@db.apache.org
Received: (qmail 15316 invoked by uid 500); 8 Oct 2010 19:19:56 -0000
Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:derby-commits-help@db.apache.org>
list-unsubscribe: <mailto:derby-commits-unsubscribe@db.apache.org>
List-Post: <mailto:derby-commits@db.apache.org>
Reply-To: "Derby Development" <derby-dev@db.apache.org>
List-Id: <derby-commits.db.apache.org>
Delivered-To: mailing list derby-commits@db.apache.org
Received: (qmail 15309 invoked by uid 99); 8 Oct 2010 19:19:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Oct 2010 19:19:55 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Oct 2010 19:19:55 +0000
Received: by eris.apache.org (Postfix, from userid 65534)
	id 6A3FF23888D2; Fri,  8 Oct 2010 19:19:35 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1005976 - /db/derby/code/trunk/build.xml
Date: Fri, 08 Oct 2010 19:19:35 -0000
To: derby-commits@db.apache.org
From: rhillegas@apache.org
X-Mailer: svnmailer-1.0.8
Message-Id: <20101008191935.6A3FF23888D2@eris.apache.org>

Author: rhillegas
Date: Fri Oct  8 19:19:35 2010
New Revision: 1005976

URL: http://svn.apache.org/viewvc?rev=1005976&view=rev
Log:
DERBY-2573: Don't build a release if there are outstanding edits still hanging around in your docs or code clients.

Modified:
    db/derby/code/trunk/build.xml

Modified: db/derby/code/trunk/build.xml
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/build.xml?rev=1005976&r1=1005975&r2=1005976&view=diff
==============================================================================
--- db/derby/code/trunk/build.xml (original)
+++ db/derby/code/trunk/build.xml Fri Oct  8 19:19:35 2010
@@ -1836,6 +1836,35 @@
      </exec>
    </target>
 
+   <!-- Verify that both the code and docs clients have no in-flight edits -->
+   <target name="checksvnclientsclean" unless="debug.release.build">
+
+      <antcall target="checksvnclean">
+         <param name="client.root" value="${docs.root}"/>
+      </antcall>
+
+      <antcall target="checksvnclean">
+         <param name="client.root" value="${basedir}"/>
+      </antcall>
+
+   </target>
+
+   <!-- Check that a subversion client has no files checked out -->
+   <target name="checksvnclean">
+     <exec executable="svn"
+           outputproperty="svnstatusoutput"
+     >
+       <arg value="status"/>
+       <arg value="${client.root}"/>
+     </exec>
+
+     <fail message="Cannot build a release. The ${client.root} subversion client is not clean: ${svnstatusoutput}">
+         <condition>
+             <not><equals arg1="${svnstatusoutput}" arg2="" trim="true"/></not>
+         </condition>
+     </fail>     
+   </target>
+
    <!-- Checkin the generated error documentation to the docs client -->
    <target name="copyerrordocs">
 
@@ -2457,11 +2486,8 @@ you should not have to do this.
     </target>
 
     <!-- do most of the ant calls to prepare a release -->
-    <target name="prepareforrelease" depends="checkdocsroot,promptforreleaseproperties,checkstateremoved,checksanenotset,cleanalljars,cleandocs,clobber,cleanreleasefiles">
+    <target name="prepareforrelease" depends="checkdocsroot,checksvnclientsclean,promptforreleaseproperties,checkstateremoved,checksanenotset,cleanalljars,cleandocs,clobber,cleanreleasefiles">
 
-        <!-- other possible checks? maybe no checked out files? -->
-        <!-- maybe try to force a doc build? call to ant release will check for docs out -->
-        <!-- assume svn update has been done to the desired level -->
         <!-- we should already be squeeky clean, depends removed jars, javadoc, snapshot, classes, and old release artifacts -->
         <antcall target="updatesvnclients"/>