db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r942480 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java
Date Sat, 08 May 2010 23:30:41 GMT
Author: dag
Date: Sat May  8 23:30:41 2010
New Revision: 942480

URL: http://svn.apache.org/viewvc?rev=942480&view=rev
Log:
DERBY-4179 bootLock.java fails with missing exception on z/OS with pmz3160sr2ifix-20081021_01(SR2+IZ32776+IZ33456),
and Windows Vista

Followup comment fix.

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java?rev=942480&r1=942479&r2=942480&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/store/BootLockTest.java
Sat May  8 23:30:41 2010
@@ -119,12 +119,12 @@ public class BootLockTest extends BaseJD
         // can check that we get DATA_MULTIPLE_JBMS_FORCE_LOCK if we set
         // derby.database.forceDatabaseLock.
 
-        // FIXME: I tried to use the DatabasePropertyTestSetup.singleProperty,
-        // but for some reason it failed to do the job, no matter where in the
-        // decorator stack in decorateTest I placed it. Should be investigated
-        // so this manual set/reset code of the property can be removed.
-
         if (JDBC.vmSupportsJSR169()) {
+            // Can't use the DatabasePropertyTestSetup.singleProperty, since
+            // that method sets a database property (not a system property),
+            // and the minion is the one creating the database here. An
+            // alternative would be to let minion set it.
+
             oldPropValue =
                 System.getProperty("derby.database.forceDatabaseLock");
             System.setProperty("derby.database.forceDatabaseLock", "true");



Mime
View raw message