Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 56977 invoked from network); 14 Dec 2009 08:30:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Dec 2009 08:30:23 -0000 Received: (qmail 56529 invoked by uid 500); 14 Dec 2009 08:30:23 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 56479 invoked by uid 500); 14 Dec 2009 08:30:22 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 56470 invoked by uid 99); 14 Dec 2009 08:30:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2009 08:30:22 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2009 08:30:20 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 2479223888DC; Mon, 14 Dec 2009 08:30:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r890220 - in /db/derby/code/trunk/java/engine/org/apache/derby/iapi: types/SqlXmlUtil.java util/StringUtil.java Date: Mon, 14 Dec 2009 08:30:00 -0000 To: derby-commits@db.apache.org From: kristwaa@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091214083000.2479223888DC@eris.apache.org> Author: kristwaa Date: Mon Dec 14 08:29:59 2009 New Revision: 890220 URL: http://svn.apache.org/viewvc?rev=890220&view=rev Log: DERBY-4473: [patch] remove some allocated but unused objects Removed the allocation of a StringWriter and a StringBuffer object. Patch contributed by Dave Brosius (dbrosius at mebigfatguy dot com). Patch file: ds.diff Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java db/derby/code/trunk/java/engine/org/apache/derby/iapi/util/StringUtil.java Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java?rev=890220&r1=890219&r2=890220&view=diff ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java Mon Dec 14 08:29:59 2009 @@ -680,8 +680,6 @@ */ private void loadSerializer() throws java.io.IOException { - java.io.StringWriter sWriter = new java.io.StringWriter(); - // Set serialization properties. Properties props = OutputProperties.getDefaultMethodProperties("xml"); Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/util/StringUtil.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/iapi/util/StringUtil.java?rev=890220&r1=890219&r2=890220&view=diff ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/iapi/util/StringUtil.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/util/StringUtil.java Mon Dec 14 08:29:59 2009 @@ -531,7 +531,6 @@ * @param depth indentation level the string is to be printed at (0,1,2..) */ public static String ensureIndent(String formatted, int depth) { - StringBuffer buf = new StringBuffer(); StringBuffer indent = new StringBuffer(); while (depth-- > 0) {