Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 99615 invoked from network); 5 May 2009 07:22:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 May 2009 07:22:06 -0000 Received: (qmail 83613 invoked by uid 500); 5 May 2009 07:22:05 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 83571 invoked by uid 500); 5 May 2009 07:22:05 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 83559 invoked by uid 99); 5 May 2009 07:22:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2009 07:22:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 May 2009 07:22:03 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id F156E23888AF; Tue, 5 May 2009 07:16:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r771597 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java Date: Tue, 05 May 2009 07:16:41 -0000 To: derby-commits@db.apache.org From: kahatlen@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090505071641.F156E23888AF@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: kahatlen Date: Tue May 5 07:16:41 2009 New Revision: 771597 URL: http://svn.apache.org/viewvc?rev=771597&view=rev Log: Use helper methods in OffsetFetchNextTest to make it simpler and to ensure that statements are closed. Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java?rev=771597&r1=771596&r2=771597&view=diff ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/OffsetFetchNextTest.java Tue May 5 07:16:41 2009 @@ -130,15 +130,12 @@ public void testNewKeywordNonReserved() throws Exception { - getConnection().prepareStatement( - "select a,b as OFFSET from t1 OFFSET 0 rows"); + prepareStatement("select a,b as OFFSET from t1 OFFSET 0 rows"); // Column and table correlation name usage - getConnection().prepareStatement( - "select a,b from t1 AS OFFSET"); + prepareStatement("select a,b from t1 AS OFFSET"); - getConnection().prepareStatement( - "select a,b OFFSET from t1 OFFSET"); + prepareStatement("select a,b OFFSET from t1 OFFSET"); } @@ -366,7 +363,7 @@ Statement stm = createStatement(ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_UPDATABLE); - getConnection().setAutoCommit(false); + setAutoCommit(false); /* * offset 0 rows (a no-op), update a row and verify result @@ -461,7 +458,7 @@ Statement stm = createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_UPDATABLE); - getConnection().setAutoCommit(false); + setAutoCommit(false); /* * offset 0 rows (a no-op), update a row and verify result @@ -616,13 +613,13 @@ public void testBigTable() throws SQLException { Statement stm = createStatement(); - getConnection().setAutoCommit(false); + setAutoCommit(false); stm.executeUpdate("declare global temporary table session.t (i int) " + "on commit preserve rows not logged"); PreparedStatement ps = - getConnection().prepareStatement("insert into session.t values ?"); + prepareStatement("insert into session.t values ?"); for (int i=1; i <= 100000; i++) { ps.setInt(1, i);