db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kahat...@apache.org
Subject svn commit: r663064 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java
Date Wed, 04 Jun 2008 11:24:10 GMT
Author: kahatlen
Date: Wed Jun  4 04:24:10 2008
New Revision: 663064

URL: http://svn.apache.org/viewvc?rev=663064&view=rev
Log:
Minor changes in J2EEDataSourceTest:
  * made more javadoc comments visible
  * used a utility method to traverse a ResultSet

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java?rev=663064&r1=663063&r2=663064&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/J2EEDataSourceTest.java
Wed Jun  4 04:24:10 2008
@@ -2945,7 +2945,7 @@
         assertIsoLocks(newconn, Connection.TRANSACTION_READ_COMMITTED);
     }
 
-    /*
+    /**
      * insert two rows into the simple table for DERBY-1144 tests
      * @param conn
      * @throws SQLException
@@ -2959,12 +2959,12 @@
         conn.commit ();
     }
     
-    /* 
+    /**
      * Checks locks for designated isolation level on the connection.
      * Currently only supports TRANSACTION_READ_COMMITTED and 
      * TRANSACTION_READ_UNCOMMITTED
      * @param conn   Connection to test
-     * @param isoLevel expected isolation level
+     * @param expectedIsoLevel expected isolation level
      *
      */
     private void assertIsoLocks(Connection conn, int expectedIsoLevel)
@@ -2984,7 +2984,7 @@
         }
     }
     
-    /*
+    /**
      * Determine if a select on this connection during update will timeout.
      * Used to establish isolation level.  If the connection isolation level
      * is <code> Connection.TRANSACTION_READ_UNCOMMITTED </code> it will not
@@ -3010,9 +3010,9 @@
 
             // now see if we can select them
             Statement stmt = conn.createStatement();
-            ResultSet rs = stmt.executeQuery("Select * from intTable");
-            while (rs.next()){};
-            rs.close();
+            JDBC.assertDrainResults(
+                stmt.executeQuery("Select * from intTable"));
+            stmt.close();
         }
         catch (SQLException e)
         {



Mime
View raw message