db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject svn commit: r647425 - /db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java
Date Sat, 12 Apr 2008 11:10:54 GMT
Author: dyre
Date: Sat Apr 12 04:10:53 2008
New Revision: 647425

URL: http://svn.apache.org/viewvc?rev=647425&view=rev
Log:
DERBY-3227: Remove final from all getConnection() methods in EmbeddedDataSource
Patch contributed by Aaron Digulla
Patch file: derby-3227.diff

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java?rev=647425&r1=647424&r2=647425&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java Sat Apr
12 04:10:53 2008
@@ -407,7 +407,8 @@
 	}
 
 	/*
-	 * DataSource methods 
+	 * DataSource methods - keep these non-final so that others can
+	 * extend Derby's classes if they choose to.
 	 */
 
 
@@ -417,7 +418,7 @@
 	 * @return  a Connection to the database
 	 * @exception SQLException if a database-access error occurs.
 	 */
-	public final Connection getConnection() throws SQLException
+	public Connection getConnection() throws SQLException
 	{
 		return this.getConnection(getUser(), getPassword(), false);
 	}
@@ -434,7 +435,7 @@
 	 * @return  a Connection to the database
 	 * @exception SQLException if a database-access error occurs.
 	 */
-	public final Connection getConnection(String username, String password) 
+	public Connection getConnection(String username, String password) 
 		 throws SQLException
 	{
 		return this.getConnection(username, password, true);



Mime
View raw message