db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fuzzylo...@apache.org
Subject svn propchange: r618788 - svn:log
Date Wed, 06 Feb 2008 06:21:23 GMT
Author: fuzzylogic
Revision: 618788
Modified property: svn:log

Modified: svn:log at Tue Feb  5 22:21:23 2008
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Tue Feb  5 22:21:23 2008
@@ -1,13 +1,33 @@
 DERBY-3304
 
-This commit addresses two issues. First of all, it cleanups up reset method in BaseActivation
which was doing more than
-just bringing the Activation back to pre-execution state. The method had to make itself aware
of holdability and what
-kind of resultset it was dealing with before closing or clearing the row of the resultset.
The reason for this behavior
-is commit code path was relying on Activation.reset to do more than just bringing the activation
to pre-execution state.
-I fixed this by moving this code from BaseActivation.reset to GenericLanguageConnectionContext.resetActivations.
+This commit addresses two issues. 
+
+First of all, it cleanups up reset method in BaseActivation which was doing more than just
bringing the Activation back 
+to pre-execution state. The method had to make itself aware of holdability and what
+kind of resultset it was dealing with 
+before closing or clearing the row of the resultset. The reason for this behavior 
+is commit code path was relying on 
+Activation.reset to do more than just bringing the activation to pre-execution state.
+ I fixed this by moving this code 
+from BaseActivation.reset to GenericLanguageConnectionContext.resetActivations.
+
+
 
 Additionally, in the new code in GenericLanguageConnectionContext.resetActivations, I added
the code to not close the
+
 language result sets associated with activations that do not return rows even if activation
may have holdability set to
+
 false. This will ensure that a commit inside a java procedure will not inadvertantly close
the resultset associated with
+
 the java procedure call.
 
+ Additionally, I copied some of the cleanup work(as shown below) from BaseActivation.reset
into 
+new code in GenericLanguageConnectionContext.resetActivations 
+   a.clearHeapConglomerateController(); 
+   if (!a.isSingleExecution()) 
+      a.clearWarnings(); 
+
+This code above was always getting executed at the time of commit before my commit and because
of that, I decided to copy 
+it in GenericLanguageConnectionContext.resetActivations. If anyone has any comments on this,
please let me know.
+
+(Andrew trying to change commit message for Mamta)


Mime
View raw message