db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r611272 - /db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
Date Fri, 11 Jan 2008 19:30:50 GMT
Author: djd
Date: Fri Jan 11 11:30:48 2008
New Revision: 611272

URL: http://svn.apache.org/viewvc?rev=611272&view=rev
Log:
Cleanup unnecessary check in DRDAConnThread.writeSQLCINRD() and remove code that fetched the
prepared statement but never used it.

Modified:
    db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java

Modified: db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java?rev=611272&r1=611271&r2=611272&view=diff
==============================================================================
--- db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java (original)
+++ db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java Fri Jan 11
11:30:48 2008
@@ -4121,13 +4121,8 @@
      * @throws SQLException
 	 */
 	private void writeSQLCINRD(DRDAStatement stmt) throws DRDAProtocolException,SQLException
-	{
-		ResultSet rs = null;
-        // todo ps is never used or closed - could this be a memory leak?
-        PreparedStatement ps = stmt.getPreparedStatement();
-		
-		if (!stmt.needsToSendParamData)
-			rs = stmt.getResultSet();
+	{		
+		ResultSet rs = stmt.getResultSet();
 
 		writer.createDssObject();
 		writer.startDdm(CodePoint.SQLCINRD);



Mime
View raw message