db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r603823 - in /db/derby/code/trunk/java/engine/org/apache/derby/impl: jdbc/EmbedResultSet.java sql/execute/JoinResultSet.java
Date Thu, 13 Dec 2007 05:36:27 GMT
Author: mamta
Date: Wed Dec 12 21:36:25 2007
New Revision: 603823

URL: http://svn.apache.org/viewvc?rev=603823&view=rev
Log:
DERBY-3261 and part of DERBY-3037

The outerjoin.sql was failing because the part of the runtime statistcis info was getting
erased before
LanguageResultSet.close() code collected it all. I moved the erasing of runtime stat code
so that it happened
once the stat was collected successfully.

In addition, I removed redundant code of closing and finishing the LanguageResultSet from
EmbedResultSet.java
because these steps happen as part of activation.close

I will merge this into 10.3 codeline and fire the tests there.


Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/JoinResultSet.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java?rev=603823&r1=603822&r2=603823&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java Wed Dec
12 21:36:25 2007
@@ -3642,8 +3642,6 @@
                 //execute the insert
                 org.apache.derby.iapi.sql.ResultSet rs = 
                         ps.execute(act, true, 0L); 
-                rs.close();
-                rs.finish();
                 act.close();
 
                 lcc.popStatementContext(statementContext, null);
@@ -3721,8 +3719,6 @@
             if (w != null) {
                 addWarning(w);
             }
-            rs.close();
-            rs.finish();
             act.close();
             //For forward only resultsets, after a update, the ResultSet will be positioned
right before the next row.
             if (getType() == TYPE_FORWARD_ONLY) {
@@ -3785,8 +3781,6 @@
                 if (w != null) {
                     addWarning(w);
                 }
-                rs.close();
-                rs.finish();
                 act.close();
                 //After a delete, the ResultSet will be positioned right before 
                 //the next row.

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/JoinResultSet.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/JoinResultSet.java?rev=603823&r1=603822&r2=603823&view=diff
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/JoinResultSet.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/execute/JoinResultSet.java Wed
Dec 12 21:36:25 2007
@@ -198,7 +198,6 @@
 	 */
 	public void	close() throws StandardException
 	{
-		clearScanState();
 
 		if ( isOpen )
 	    {
@@ -214,6 +213,7 @@
 			if (SanityManager.DEBUG)
 				SanityManager.DEBUG("CloseRepeatInfo","Close of JoinResultSet repeated");
 
+		clearScanState();
 	}
 
 	public void finish() throws StandardException {



Mime
View raw message