db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From myrn...@apache.org
Subject svn commit: r596177 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
Date Mon, 19 Nov 2007 01:54:40 GMT
Author: myrnavl
Date: Sun Nov 18 17:54:39 2007
New Revision: 596177

URL: http://svn.apache.org/viewvc?rev=596177&view=rev
Log:
DERBY-2242 (partial); add some comments

Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java?rev=596177&r1=596176&r2=596177&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
Sun Nov 18 17:54:39 2007
@@ -463,6 +463,13 @@
         assertFalse(dmd.dataDefinitionCausesTransactionCommit());
         assertFalse(dmd.dataDefinitionIgnoredInTransactions());
         
+        // Derby does not yet implement scroll sensitive resultsets, so can't
+        //   see changes for those; all *AreDetected and *AreVisible methods
+        //   return false.
+        // For Forward Only ResultSets, also see lang.UpdatableResultSetTest
+        
+        // *AreDetected; expect true for updates and deletes of 
+        //   TYPE_SCROLL_INSENSITIVE, all others should be false
         assertFalse(dmd.deletesAreDetected(ResultSet.TYPE_FORWARD_ONLY));
         assertTrue(dmd.deletesAreDetected(ResultSet.TYPE_SCROLL_INSENSITIVE));
         assertFalse(dmd.deletesAreDetected(ResultSet.TYPE_SCROLL_SENSITIVE));
@@ -473,6 +480,11 @@
         assertTrue(dmd.updatesAreDetected(ResultSet.TYPE_SCROLL_INSENSITIVE));
         assertFalse(dmd.updatesAreDetected(ResultSet.TYPE_SCROLL_SENSITIVE));
         
+        // others*AreVisible
+        // Since Derby materializes a forward only ResultSet incrementally, 
+        //   it is possible to see changes for FORWARD_ONLY
+        // Scroll insensitive ResultSet by their definition do not see changes
+        //   made by others
         assertTrue(dmd.othersDeletesAreVisible(ResultSet.TYPE_FORWARD_ONLY));
         assertFalse(dmd.othersDeletesAreVisible(ResultSet.TYPE_SCROLL_INSENSITIVE));
         assertFalse(dmd.othersDeletesAreVisible(ResultSet.TYPE_SCROLL_SENSITIVE));
@@ -483,6 +495,7 @@
         assertFalse(dmd.othersUpdatesAreVisible(ResultSet.TYPE_SCROLL_INSENSITIVE));
         assertFalse(dmd.othersUpdatesAreVisible(ResultSet.TYPE_SCROLL_SENSITIVE));
         
+        // Scroll insensitive ResultSets see updates, deletes, but not inserts
         assertFalse(dmd.ownDeletesAreVisible(ResultSet.TYPE_FORWARD_ONLY));
         assertTrue(dmd.ownDeletesAreVisible(ResultSet.TYPE_SCROLL_INSENSITIVE));
         assertFalse(dmd.ownDeletesAreVisible(ResultSet.TYPE_SCROLL_SENSITIVE));



Mime
View raw message