Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 95256 invoked from network); 10 Jul 2007 21:01:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jul 2007 21:01:06 -0000 Received: (qmail 78316 invoked by uid 500); 10 Jul 2007 21:01:08 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 78282 invoked by uid 500); 10 Jul 2007 21:01:08 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 78271 invoked by uid 99); 10 Jul 2007 21:01:08 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2007 14:01:08 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2007 14:01:05 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 8D0C81A981A; Tue, 10 Jul 2007 14:00:44 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r555075 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java Date: Tue, 10 Jul 2007 21:00:44 -0000 To: derby-commits@db.apache.org From: kmarsden@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070710210044.8D0C81A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: kmarsden Date: Tue Jul 10 14:00:43 2007 New Revision: 555075 URL: http://svn.apache.org/viewvc?view=rev&rev=555075 Log: DERBY-2893 Fix GrantRevokeTest to use correct user for assertInsertPrivilege Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java?view=diff&rev=555075&r1=555074&r2=555075 ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/GrantRevokeTest.java Tue Jul 10 14:00:43 2007 @@ -1045,7 +1045,7 @@ // NOTE - getColumns returns empty result set if schema / table names not capitalized. // TODO - should implement asserting insert privilege on a subset of columns at some point - Connection c = openUserConnection(users[0]); + Connection c = openUserConnection(user); Statement s = c.createStatement(); try { @@ -1063,13 +1063,12 @@ rs.close(); command.append(")"); int i = s.executeUpdate(command.toString()); - // DERBY-2893 INSERT seems to succeed. - //if (!hasPrivilege) - // fail("expected no INSERT permission on table"); + if (!hasPrivilege) + fail("expected no INSERT permission on table"); } catch (SQLException e) { if (!hasPrivilege) { - assertSQLState("42502", e); + assertSQLState("42500", e); } else { fail("Unexpected lack of insert privilege on " + schema + "." + table + " by " + user); } @@ -1130,9 +1129,8 @@ assertEquals(columnCount, actualCount); } - // DERBY-2893 UPDATE seems to succeed. - //if (!hasPrivilege) - // fail("expected no UPDATE permission on table"); + if (!hasPrivilege) + fail("expected no UPDATE permission on table"); } catch (SQLException e) { if (!hasPrivilege) {