db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r553793 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
Date Fri, 06 Jul 2007 08:47:04 GMT
Author: mamta
Date: Fri Jul  6 01:47:03 2007
New Revision: 553793

URL: http://svn.apache.org/viewvc?view=rev&rev=553793
Log:
DERBY-2777

We were incorrectly trying to set collation info on non-character string types. This commit
will remove that code.


Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java?view=diff&rev=553793&r1=553792&r2=553793
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
Fri Jul  6 01:47:03 2007
@@ -905,14 +905,25 @@
         }
     } // end of bindDateTimeArg
 
+    /**
+     * This method gets called for non-character string types and hence no need 
+     * to set any collation info. Collation applies only to character string
+     * types.
+     *  
+     * @param arg Check if arg is a ? param and if yes, then set it's type to
+     *    jdbcType if arg doesn't have a type associated with it.
+     *    
+     * @param jdbcType Associate this type with arg if arg is a ? param with no
+     *    type associated with it
+     *    
+     * @return true if arg is a ? param with no type associated with it
+     * @throws StandardException
+     */
     private boolean bindParameter( ValueNode arg, int jdbcType) throws StandardException
     {
         if( arg.requiresTypeFromContext() && arg.getTypeId() == null)
         {
             arg.setType( new DataTypeDescriptor(TypeId.getBuiltInTypeId( jdbcType), true));
-			//collation of ? operand should be same as the compilation schema
-			arg.setCollationUsingCompilationSchema(
-					StringDataValue.COLLATION_DERIVATION_IMPLICIT);
             return true;
         }
         return false;



Mime
View raw message