Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 44158 invoked from network); 5 Jun 2007 06:28:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jun 2007 06:28:04 -0000 Received: (qmail 83259 invoked by uid 500); 5 Jun 2007 06:28:08 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 83195 invoked by uid 500); 5 Jun 2007 06:28:07 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 83184 invoked by uid 99); 5 Jun 2007 06:28:07 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jun 2007 23:28:07 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Jun 2007 23:28:03 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id C2C041A981A; Mon, 4 Jun 2007 23:27:42 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r544403 - /db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java Date: Tue, 05 Jun 2007 06:27:42 -0000 To: derby-commits@db.apache.org From: kahatlen@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070605062742.C2C041A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: kahatlen Date: Mon Jun 4 23:27:41 2007 New Revision: 544403 URL: http://svn.apache.org/viewvc?view=rev&rev=544403 Log: DERBY-2753: DDMWriter might swallow unexpected exceptions Replaced generic "catch (Exception e)" clauses with more specific "catch (UnsupportedEncodingException e)" clauses. Modified: db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java Modified: db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java?view=diff&rev=544403&r1=544402&r2=544403 ============================================================================== --- db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java (original) +++ db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DDMWriter.java Mon Jun 4 23:27:41 2007 @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.BufferedInputStream; import java.io.BufferedOutputStream; +import java.io.UnsupportedEncodingException; import org.apache.derby.iapi.services.sanity.SanityManager; import java.sql.SQLException; import java.sql.DataTruncation; @@ -1241,7 +1242,7 @@ writeShort(writeLen); writeBytes(byteval,writeLen); } - catch (Exception e) { + catch (UnsupportedEncodingException e) { //this should never happen agent.agentError("Encoding " + NetworkServerControlImpl.DEFAULT_ENCODING + " not supported"); } @@ -1261,7 +1262,7 @@ { try { writeBytes(s.getBytes(NetworkServerControlImpl.DEFAULT_ENCODING)); - } catch (Exception e) { + } catch (UnsupportedEncodingException e) { //this should never happen agent.agentError("Encoding " + NetworkServerControlImpl.DEFAULT_ENCODING + " not supported"); } @@ -1280,7 +1281,7 @@ byte[] bs = null; try { bs = s.getBytes(NetworkServerControlImpl.DEFAULT_ENCODING); - } catch (Exception e) { + } catch (UnsupportedEncodingException e) { //this should never happen agent.agentError("Encoding " + NetworkServerControlImpl.DEFAULT_ENCODING + " not supported"); }