db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kahat...@apache.org
Subject svn commit: r546126 - in /db/derby/code/trunk/java: client/org/apache/derby/client/am/DatabaseMetaData.java engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
Date Mon, 11 Jun 2007 12:36:05 GMT
Author: kahatlen
Date: Mon Jun 11 05:36:04 2007
New Revision: 546126

URL: http://svn.apache.org/viewvc?view=rev&rev=546126
Log:
DERBY-2789: DatabaseMetaData.locatorsUpdateCopy() should return true

Contributed by Øystein Grøvlen.

Modified:
    db/derby/code/trunk/java/client/org/apache/derby/client/am/DatabaseMetaData.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java

Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/DatabaseMetaData.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/am/DatabaseMetaData.java?view=diff&rev=546126&r1=546125&r2=546126
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/am/DatabaseMetaData.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/am/DatabaseMetaData.java Mon Jun
11 05:36:04 2007
@@ -2253,7 +2253,7 @@
 
     public boolean locatorsUpdateCopy() throws SQLException {
         checkForClosedConnection();
-        return false;
+        return true;
     }
 
     public boolean supportsStatementPooling() throws SQLException {

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java?view=diff&rev=546126&r1=546125&r2=546126
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java
Mon Jun 11 05:36:04 2007
@@ -3278,6 +3278,9 @@
     *
     * Indicates whether updates made to a LOB are made on a copy or
     * directly to the LOB.
+    * <p>
+    * For the embedded driver, all updates will be made to a copy.
+    * Hence, this call will always return <code>true</code>
     *
     * @return true if updates are made to a copy of the LOB; false if
     * updates are made directly to the LOB
@@ -3286,7 +3289,7 @@
 	public boolean locatorsUpdateCopy()
     throws SQLException
 	{
-		return false;
+		return true;
 	}
 
 	/**

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java?view=diff&rev=546126&r1=546125&r2=546126
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
Mon Jun 11 05:36:04 2007
@@ -492,7 +492,7 @@
         
         assertFalse(dmd.isCatalogAtStart()); 
         
-        assertFalse(dmd.locatorsUpdateCopy());
+        assertTrue(dmd.locatorsUpdateCopy());
         
         assertTrue(dmd.usesLocalFilePerTable());
         assertTrue(dmd.usesLocalFiles());



Mime
View raw message