db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r539050 - in /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile: InListOperatorNode.java IsNullNode.java
Date Thu, 17 May 2007 18:02:50 GMT
Author: djd
Date: Thu May 17 11:02:47 2007
New Revision: 539050

URL: http://svn.apache.org/viewvc?view=rev&rev=539050
Log:
Cleanup a couple of cases in query tree nodes to remove unnecessary casting of a DataValueDescriptor.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/InListOperatorNode.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/IsNullNode.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/InListOperatorNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/InListOperatorNode.java?view=diff&rev=539050&r1=539049&r2=539050
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/InListOperatorNode.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/InListOperatorNode.java
Thu May 17 11:02:47 2007
@@ -258,8 +258,7 @@
 				/* Now wort the list in ascending order using the dominant
 				 * type found above.
 				 */
-				DataValueDescriptor judgeODV =
-					(DataValueDescriptor)targetType.getTypeId().getNull();
+				DataValueDescriptor judgeODV = targetType.getNull();
 
 				rightOperandList.sortInAscendingOrder(judgeODV);
 				isOrdered = true;

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/IsNullNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/IsNullNode.java?view=diff&rev=539050&r1=539049&r2=539050
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/IsNullNode.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/IsNullNode.java Thu
May 17 11:02:47 2007
@@ -56,7 +56,7 @@
 						implements RelationalOperator
 {
 
-	Object nullValue = null;
+	private DataValueDescriptor nullValue;
 
 	public void setNodeType(int nodeType)
 	{
@@ -245,10 +245,10 @@
 	{
 		if (nullValue == null)
 		{
-			nullValue = operand.getTypeId().getNull();
+			nullValue = operand.getTypeServices().getNull();
 		}
 
-		return (DataValueDescriptor) nullValue;
+		return nullValue;
 	}
 
 	/** @see RelationalOperator#equalsComparisonWithConstantExpression */



Mime
View raw message