db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Db-derby Wiki] Update of "PatchAdvice" by KatheyMarsden
Date Mon, 07 May 2007 18:23:30 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Db-derby Wiki" for change notification.

The following page has been changed by KatheyMarsden:
http://wiki.apache.org/db-derby/PatchAdvice

------------------------------------------------------------------------------
   1. Post to the list at least every couple of weeks if you don't get review. Ask if someone
is available to look at  your patch and what additional information reviewers might need for
review.
   2. If you are new to the project, call that out and indicate that you have filed your ICLA.

   3. Point out attractive or interesting features of your patch like new test cases covered,
user scenarios that will benefit or may be impacted, relationships to other Jira issues, etc.
This will get the attention of those who might not otherwise review.
-  4. Run   derbyall and include your test results. Then reviewers know the review is probably
smooth sailing and not a big time committment.
+  4. Run   derbyall and suites.All and include your test results. Then reviewers know the
review is probably smooth sailing and not a big time committment.
   5. Keep your patch up to date and ready for anyone who might be willing to pick it up to
review.
   6. If you get no response from the list, encourage other developers you know and see on
IRC or elsewhere to try out or review the patch. Don't focus on just committers. The committer
is the last reviewer but ideally is not the first.
   7.  Review or try out  patches submitted by others. Somebody might review your patch in
turn. This is also good for your accumulated merit and a great learning opportunity. 

Mime
View raw message