db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r531138 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java
Date Sun, 22 Apr 2007 03:47:17 GMT
Author: mamta
Date: Sat Apr 21 20:47:16 2007
New Revision: 531138

URL: http://svn.apache.org/viewvc?view=rev&rev=531138
Log:
DERBY-2578 I am starting to think about the code generation for DERBY-1478 language based
ordering. Depending on the collation type of 
the DTD, we might want to generate CollatorSQLChar rather than SQLChar for instance. In order
to centralize this code, I am changing 
CurrentDatetimeOperatorNode's generateExpression so that it goes through ExpressionClassBuilder.generateDataValue
rather than doing 
TypeCompiler.generateDataValue. This way, hopefully, I will only have to change ExpressionClassBuilder.generateDataValue
to take care of 
the collation dependency of DVD generation. All the other classes which need to generate a
DVD already go through 
ExpressionClassBuilder.generateDataValue. The tests have passed with no new failures. 


Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java?view=diff&rev=531138&r1=531137&r2=531138
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java
(original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CurrentDatetimeOperatorNode.java
Sat Apr 21 20:47:16 2007
@@ -143,8 +143,6 @@
 											MethodBuilder mb)
 									throws StandardException
 	{
-		acb.pushDataValueFactory(mb);
-
 		/*
 		** First, we generate the current expression to be stuffed into
 		** the right shape of holder.
@@ -161,9 +159,7 @@
 				break;
 		}
 
-		String fieldType = getTypeCompiler().interfaceName();
-		LocalField field = acb.newFieldDeclaration(Modifier.PRIVATE, fieldType);
-		getTypeCompiler().generateDataValue(mb, field);
+		acb.generateDataValue(mb, getTypeCompiler(), (LocalField)null);
 	}
 
 	/*



Mime
View raw message