db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mi...@apache.org
Subject svn commit: r529764 - in /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests: master/compressTable.out tests/lang/compressTable.sql
Date Tue, 17 Apr 2007 21:07:49 GMT
Author: mikem
Date: Tue Apr 17 14:07:48 2007
New Revision: 529764

URL: http://svn.apache.org/viewvc?view=rev&rev=529764
Log:
DERBY-2117
This test was incorrectly depending on the exact free page state subsequent
to a delete.  This state is very timing dependent on when the post commit
thread can run so should not be used in tests to be run across a wide range
of platforms/machines.  I just got rid of the select of the state after the
delete, and left the rest of the test case.


Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/compressTable.out
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/compressTable.sql

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/compressTable.out
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/compressTable.out?view=diff&rev=529764&r1=529763&r2=529764
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/compressTable.out
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/compressTable.out
Tue Apr 17 14:07:48 2007
@@ -1312,11 +1312,11 @@
 T1                                                                                      
                                       |3                   |0                   
 ij> delete from t1;
 26 rows inserted/updated/deleted
-ij> select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
-CONGLOMERATENAME                                                                        
                                       |NUMALLOCATEDPAGES   |NUMFREEPAGES        
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-T1                                                                                      
                                       |1                   |2                   
-ij> call syscs_util.syscs_inplace_compress_table('APP','T1',2,2,2);
+ij> -- don't check result from delete as the number of free pages is system
+-- performance dependent.  It depends on how quickly post commit can run and
+-- reclaim the space, the result will not be reproducible across all platforms.
+-- select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
+call syscs_util.syscs_inplace_compress_table('APP','T1',2,2,2);
 0 rows inserted/updated/deleted
 ij> select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
 CONGLOMERATENAME                                                                        
                                       |NUMALLOCATEDPAGES   |NUMFREEPAGES        

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/compressTable.sql
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/compressTable.sql?view=diff&rev=529764&r1=529763&r2=529764
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/compressTable.sql
(original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/compressTable.sql
Tue Apr 17 14:07:48 2007
@@ -595,7 +595,12 @@
 insert into t1 values 'a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v','w','x','y','z';
 select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
 delete from t1;
-select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
+-- don't check result from delete as the number of free pages is system
+-- performance dependent.  It depends on how quickly post commit can run and
+-- reclaim the space, the result will not be reproducible across all platforms.
+
+-- select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
+
 call syscs_util.syscs_inplace_compress_table('APP','T1',2,2,2);
 select conglomeratename, numallocatedpages, numfreepages from new org.apache.derby.diag.SpaceTable('T1')
tab;
 drop table t1;



Mime
View raw message