db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From krist...@apache.org
Subject svn commit: r529259 - in /db/derby/code/trunk/java/client/org/apache/derby/client/am: CallableLocatorProcedures.java PreparedStatement.java
Date Mon, 16 Apr 2007 14:19:23 GMT
Author: kristwaa
Date: Mon Apr 16 07:19:22 2007
New Revision: 529259

URL: http://svn.apache.org/viewvc?view=rev&rev=529259
Log:
DERBY-2495: Followup patch improving JavaDoc and removing use of a String constructor.

Patch contributed by Øystein Grøvlen.

Modified:
    db/derby/code/trunk/java/client/org/apache/derby/client/am/CallableLocatorProcedures.java
    db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java

Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/CallableLocatorProcedures.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/am/CallableLocatorProcedures.java?view=diff&rev=529259&r1=529258&r2=529259
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/am/CallableLocatorProcedures.java
(original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/am/CallableLocatorProcedures.java
Mon Apr 16 07:19:22 2007
@@ -38,7 +38,7 @@
  * that does not fit in a VARCHAR (FOR BIT DATA), are split into
  * several calls each operating on a fragment of the LOB.
  *
- * @see Connection.locatorProcedureCall() for an example of how to use
+ * @see Connection#locatorProcedureCall for an example of how to use
  * this class.
  */
 class CallableLocatorProcedures 
@@ -462,7 +462,8 @@
 
     /**
      * Truncates the <code>BLOB</code> value identified by
-     * <code>sourceLocator</code> to be <code>length</code> bytes.
 <p>
+     * <code>sourceLocator</code> to be <code>length</code> bytes.
 
+     * <p>
      * <b>Note:</b> If the value specified for <code>length</code>
is greater
      * than the length+1 of the <code>BLOB</code> value then an
      * <code>SQLException</code> will be thrown.
@@ -613,7 +614,8 @@
      * substring <code>searchLiteral</code> begins within the <code>CLOB</code>
      * value identified by <code>locator</code>.  The search for
      * <code>searchLiteral</code> begins at position <code>fromPosition</code>.
-     * <p> This is a helper function used by clobGetPositionFromString(int,
+     * <p> 
+     * This is a helper function used by clobGetPositionFromString(int,
      * String, long) for each call to the CLOBGETPOSITIONFROMSTRING procedure.
      *
      * @param locator locator that identifies the CLOB to be searched.
@@ -752,7 +754,7 @@
     String clobGetSubString(int sourceLocator, long fromPosition, int forLength)
         throws SqlException
     {
-        if (forLength == 0) return new String("");
+        if (forLength == 0) return "";
 
         if (clobGetSubStringCall == null) {
             clobGetSubStringCall = connection.prepareCallX

Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java?view=diff&rev=529259&r1=529258&r2=529259
==============================================================================
--- db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java (original)
+++ db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java Mon
Apr 16 07:19:22 2007
@@ -612,6 +612,7 @@
 
     void setLongX(final int parameterIndex, final long x) 
     {
+        // Column numbers starts at 1, clientParamtertype_[0] refers to column 1
         parameterMetaData_.clientParamtertype_[parameterIndex - 1] 
                 = java.sql.Types.BIGINT;
         setInput(parameterIndex, new Long(x));



Mime
View raw message