db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r482717 - in /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc: EmbedResultSet.java EmbedStatement.java
Date Tue, 05 Dec 2006 17:30:36 GMT
Author: djd
Date: Tue Dec  5 09:30:34 2006
New Revision: 482717

URL: http://svn.apache.org/viewvc?view=rev&rev=482717
Log:
Have EmbedResultSet obtain its EmbedStatement's result set concurrency directly rather than
going through the JDBC method api which in turns requires the check on if the Statement is
open.
In this case it's known the Statement is open since it is creating the ResultSet.
Mentioned as one of the optimizatons in DERBY-1876.

Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
    db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java?view=diff&rev=482717&r1=482716&r2=482717
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java Tue Dec
 5 09:30:34 2006
@@ -245,7 +245,7 @@
 		//and a warning will be issued on the ResultSet object.
 		if (stmt == null)
 			concurrencyOfThisResultSet = JDBC20Translation.CONCUR_READ_ONLY;
-		else if (stmt.getResultSetConcurrency() == JDBC20Translation.CONCUR_READ_ONLY)
+		else if (stmt.resultSetConcurrency == JDBC20Translation.CONCUR_READ_ONLY)
 			concurrencyOfThisResultSet = JDBC20Translation.CONCUR_READ_ONLY;
 		else {
 			if (!isForUpdate()) { //language resultset not updatable

Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java?view=diff&rev=482717&r1=482716&r2=482717
==============================================================================
--- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java (original)
+++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedStatement.java Tue Dec
 5 09:30:34 2006
@@ -85,7 +85,7 @@
 
 	private final boolean forMetaData;
 	final int resultSetType;
-	private final int resultSetConcurrency;
+	final int resultSetConcurrency;
 	private final int resultSetHoldability;
 	final LanguageConnectionContext lcc;
 



Mime
View raw message