Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 64264 invoked from network); 5 Nov 2006 12:47:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Nov 2006 12:47:37 -0000 Received: (qmail 29722 invoked by uid 500); 5 Nov 2006 12:47:48 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 29690 invoked by uid 500); 5 Nov 2006 12:47:48 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Delivered-To: moderator for derby-commits@db.apache.org Received: (qmail 92328 invoked by uid 99); 3 Nov 2006 18:57:40 -0000 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r470943 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java Date: Fri, 03 Nov 2006 18:57:03 -0000 To: derby-commits@db.apache.org From: abrown@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061103185703.72CDB1A984A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: abrown Date: Fri Nov 3 10:57:02 2006 New Revision: 470943 URL: http://svn.apache.org/viewvc?view=rev&rev=470943 Log: Test committer capabilities by making a small fix to comments in OptimizerImpl.java Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java?view=diff&rev=470943&r1=470942&r2=470943 ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java Fri Nov 3 10:57:02 2006 @@ -973,11 +973,14 @@ /* ** When we pull an Optimizable we need to go through and ** load whatever best path we found for that Optimizable - ** with respect to _this_ OptimizerImpl. An Optimizable - ** can have different "best paths" for different Optimizer - ** Impls if there are subqueries beneath it; we need to make - ** sure that when we pull it, it's holding the best path as - ** as we determined it to be for _us_. + ** with respect to this OptimizerImpl. The reason is that + ** we could be pulling the Optimizable for the last time + ** (before returning false), in which case we want it (the + ** Optimizable) to be holding the best access path that it + ** had at the time we found bestJoinOrder. This ensures + ** that the access path which is generated and executed for + ** the Optimizable matches the the access path decisions + ** made by this OptimizerImpl for the best join order. ** ** NOTE: We we only reload the best plan if it's necessary ** to do so--i.e. if the best plans aren't already loaded.