Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 32701 invoked from network); 22 Sep 2006 14:31:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Sep 2006 14:31:08 -0000 Received: (qmail 72864 invoked by uid 500); 22 Sep 2006 14:31:07 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 72780 invoked by uid 500); 22 Sep 2006 14:31:07 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 72725 invoked by uid 99); 22 Sep 2006 14:31:07 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2006 07:31:07 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=djd@apache.org; spf=permerror X-ASF-Spam-Status: No, hits=-9.4 required=5.0 tests=ALL_TRUSTED,NO_REAL_NAME Received-SPF: error (idunn.apache.osuosl.org: domain apache.org from 140.211.166.113 cause and error) Received: from [140.211.166.113] ([140.211.166.113:63836] helo=eris.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 01/EC-06791-5A3F3154 for ; Fri, 22 Sep 2006 07:31:03 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 9F5CF1A981A; Fri, 22 Sep 2006 07:30:54 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r448948 - /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java Date: Fri, 22 Sep 2006 14:30:54 -0000 To: derby-commits@db.apache.org From: djd@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20060922143054.9F5CF1A981A@eris.apache.org> X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: djd Date: Fri Sep 22 07:30:53 2006 New Revision: 448948 URL: http://svn.apache.org/viewvc?view=rev&rev=448948 Log: Minor cleanup in EmbedResultSet.java, code to set warning in constructor can use the addWarning() method rather than repeating code. Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java Modified: db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java?view=diff&rev=448948&r1=448947&r2=448948 ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java Fri Sep 22 07:30:53 2006 @@ -249,10 +249,7 @@ if (!isForUpdate()) { //language resultset not updatable concurrencyOfThisResultSet = JDBC20Translation.CONCUR_READ_ONLY; SQLWarning w = StandardException.newWarning(SQLState.QUERY_NOT_QUALIFIED_FOR_UPDATABLE_RESULTSET); - if (topWarning == null) - topWarning = w; - else - topWarning.setNextWarning(w); + addWarning(w); } else concurrencyOfThisResultSet = JDBC20Translation.CONCUR_UPDATABLE; }