Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 59891 invoked from network); 23 Mar 2006 12:52:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Mar 2006 12:52:11 -0000 Received: (qmail 90304 invoked by uid 500); 23 Mar 2006 12:52:11 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 90215 invoked by uid 500); 23 Mar 2006 12:52:09 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 90204 invoked by uid 99); 23 Mar 2006 12:52:09 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Mar 2006 04:52:09 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 23 Mar 2006 04:52:09 -0800 Received: (qmail 59799 invoked by uid 65534); 23 Mar 2006 12:51:48 -0000 Message-ID: <20060323125148.59798.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: svn commit: r388161 - in /db/derby/code/trunk/java: client/org/apache/derby/client/am/CrossConverters.java engine/org/apache/derby/iapi/types/SQLDouble.java Date: Thu, 23 Mar 2006 12:51:47 -0000 To: derby-commits@db.apache.org From: bernt@apache.org X-Mailer: svnmailer-1.0.7 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: bernt Date: Thu Mar 23 04:51:45 2006 New Revision: 388161 URL: http://svn.apache.org/viewcvs?rev=388161&view=rev Log: DERBY-1136 JDBC driver on rs.getFloat() gives LossOfPrecisionConversionException for float fields containing Float.MAX_VALUE Submitted by Håvard Mork Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLDouble.java Modified: db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java?rev=388161&r1=388160&r2=388161&view=diff ============================================================================== --- db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java (original) +++ db/derby/code/trunk/java/client/org/apache/derby/client/am/CrossConverters.java Thu Mar 23 04:51:45 2006 @@ -1074,7 +1074,7 @@ final float getFloatFromDouble(double source) throws SqlException { if (Configuration.rangeCheckCrossConverters && - (source > Float.MAX_VALUE || source < -Float.MAX_VALUE)) { + Float.isInfinite((float)source)) { throw new LossOfPrecisionConversionException(agent_.logWriter_, String.valueOf(source)); } Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLDouble.java URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLDouble.java?rev=388161&r1=388160&r2=388161&view=diff ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLDouble.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLDouble.java Thu Mar 23 04:51:45 2006 @@ -134,7 +134,7 @@ */ public float getFloat() throws StandardException { - if (Math.abs(value) > Float.MAX_VALUE) + if (Float.isInfinite((float)value)) throw StandardException.newException(SQLState.LANG_OUTSIDE_RANGE_FOR_DATATYPE, TypeId.REAL_NAME); return (float) value; }