Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 1427 invoked from network); 11 Mar 2006 04:19:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 11 Mar 2006 04:19:11 -0000 Received: (qmail 27901 invoked by uid 500); 11 Mar 2006 04:19:11 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 27875 invoked by uid 500); 11 Mar 2006 04:19:10 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 27864 invoked by uid 99); 11 Mar 2006 04:19:10 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2006 20:19:10 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 10 Mar 2006 20:19:10 -0800 Received: (qmail 1363 invoked by uid 65534); 11 Mar 2006 04:18:49 -0000 Message-ID: <20060311041849.1362.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r385006 - /db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java Date: Sat, 11 Mar 2006 04:18:49 -0000 To: derby-commits@db.apache.org From: djd@apache.org X-Mailer: svnmailer-1.0.7 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: djd Date: Fri Mar 10 20:18:47 2006 New Revision: 385006 URL: http://svn.apache.org/viewcvs?rev=385006&view=rev Log: Clean up dblook.java to make protected methods private to clean-up the published javadoc. Modified: db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java Modified: db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java?rev=385006&r1=385005&r2=385006&view=diff ============================================================================== --- db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java (original) +++ db/derby/code/trunk/java/tools/org/apache/derby/tools/dblook.java Fri Mar 10 20:18:47 2006 @@ -49,36 +49,34 @@ import org.apache.derby.impl.tools.dblook.DB_View; import org.apache.derby.impl.tools.dblook.Logs; -public class dblook { +public final class dblook { // DB2 enforces a maximum of 30 tables to be specified as part of // the table list. - public static final int DB2_MAX_NUMBER_OF_TABLES = 30; + private static final int DB2_MAX_NUMBER_OF_TABLES = 30; private Connection conn; private static PreparedStatement getColNameFromNumberQuery; // Mappings from id to name for schemas and tables (for ease // of reference). - protected static HashMap schemaMap; - protected static HashMap tableIdToNameMap; + private static HashMap schemaMap; + private static HashMap tableIdToNameMap; // Command-line Parameters. - protected static String sourceDBUrl; - protected static String ddlFileName; - protected static String stmtDelimiter; - protected static boolean appendLogs; - protected static ArrayList tableList; - protected static String schemaParam; - protected static String targetSchema; - protected static boolean skipViews; - protected static boolean verbose; + private static String sourceDBUrl; + private static String ddlFileName; + private static String stmtDelimiter; + private static boolean appendLogs; + private static ArrayList tableList; + private static String schemaParam; + private static String targetSchema; + private static boolean skipViews; + private static boolean verbose; private static String sourceDBName; private static String lookLogName = "dblook.log"; - private final static String DEFAULT_LOCALE= "en"; - private final static String DEFAULT_LOCALE_COUNTRY="US"; private static LocalizedResource langUtil; /* ************************************************ @@ -341,7 +339,7 @@ * path, if provided) that is referenced by the url. ****/ - protected String extractDBNameFromUrl(String dbUrl) { + private String extractDBNameFromUrl(String dbUrl) { if (dbUrl == null) // shouldn't happen; ignore it here, as an error @@ -804,7 +802,7 @@ * false otherwise; ****/ - public static final String[] ignorableSchemaNames = { + private static final String[] ignorableSchemaNames = { "SYSIBM", "SYS", "SYSVISUAL",