db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Db-derby Wiki] Update of "DerbyCommitProcess" by BryanPendleton
Date Thu, 23 Feb 2006 22:39:05 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Db-derby Wiki" for change notification.

The following page has been changed by BryanPendleton:

     The above three steps are repeated until there is consensus that the change is ready.
   * The developer signals that the patch is ready to be committed by checking the "patch
available" checkbox. The developer may also send a message to derby-dev requesting the attention
of a committer.
   * A committer sends a message to derby-dev indicating that she intends to review and commit
the change.
-  * The committer applies the patch to the current trunk and verifies that it applies cleanly
and passes derbyall.
+  * The committer applies the patch to the current trunk and verifies that it applies cleanly.
   * The committer reviews the change. Good practices to follow here include: 
     * close reading of the diff, 
     * exploratory testing of specific changes of interest, 
     * verifying that the regression test(s) fail without the code change(s) and pass once
the code changes are applied.
+    * possibly running some or all of the [http://svn.apache.org/repos/asf/db/derby/code/trunk/java/testing/README.htm
regression test suites], as the committer deems relevant.
   * When the committer is satisfied that the change is ready, the committer issues the "svn
commit" to commit the change. In the commit log message, the committer should include information
that ties back to the JIRA issue (the Jira bug number in the format DERBY-XXX anywhere in
the commit message) and to the developer who made the change.
   * The committer updates the JIRA entry to:
     * clear the "patch available" checkbox 
@@ -25, +26 @@

  Note that Derby as a Apache DB sub-project follows the [http://db.apache.org/guidelines.html
Apache DB guidelines] .
+ Committers should read the [http://www.apache.org/dev/new-committers-guide.html overall
guidelines for committers].
  This includes the [http://www.apache.org/foundation/glossary.html#CommitThenReview Commit-Then-Review]

View raw message