db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apache Wiki <wikidi...@apache.org>
Subject [Db-derby Wiki] Update of "DerbyCommitProcess" by BryanPendleton
Date Thu, 23 Feb 2006 16:20:32 GMT
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Db-derby Wiki" for change notification.

The following page has been changed by BryanPendleton:

   * The developer attaches the change proposal, in "svn diff" format, to the JIRA entry
   * Other Derby developers review the change proposal and provide feedback.
   * The above three steps are repeated until there is consensus that the change is ready.
-  * ... to be continued (sorry I had to run to a meeting) ...
+  * The developer signals that the patch is ready to be committed by checking the "patch
available" checkbox.
+  * A committer sends a message to derby-dev indicating that she intends to review and commit
the change.
+  * The committer applies the patch to the current trunk and verifies that it applies cleanly
and passes derbyall.
+  * The committer reviews the change. Good practices to follow here include: close reading
of the diff, exploratory testing of specific changes of interest, verifying that the regression
test(s) fail without the code change(s) and pass once the code changes are applied.
+  * When the committer is satisfied that the change is ready, the committer issues the "svn
commit" to commit the change. In the commit log message, the committer should include information
that ties back to the JIRA issue and to the developer who made the change.
+  * The committer updates the JIRA entry to clear the "patch available" checkbox and to mark
the issue as resolved. It is useful to include a comment with information about the revision
number, for example as a hyperlink to the SVN revision viewer for that revision.
+  * Either the developer or the original assignee should then verify that the patch was successfully
applied, and that the original problem is now resolved, and closes the JIRA.

View raw message