db-derby-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d..@apache.org
Subject svn commit: r379257 - /db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
Date Mon, 20 Feb 2006 22:22:06 GMT
Author: djd
Date: Mon Feb 20 14:22:02 2006
New Revision: 379257

URL: http://svn.apache.org/viewcvs?rev=379257&view=rev
Log:
Remove some dead code in DRDAConnThread where a result set or prepared statement
reference was obtained but never used. There were no side-effects in any of the
methods called.

Modified:
    db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java

Modified: db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java?rev=379257&r1=379256&r2=379257&view=diff
==============================================================================
--- db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java (original)
+++ db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java Mon Feb 20
14:22:02 2006
@@ -55,9 +55,7 @@
 import org.apache.derby.iapi.services.stream.HeaderPrintWriter;
 import org.apache.derby.iapi.tools.i18n.LocalizedResource;
 import org.apache.derby.impl.jdbc.EmbedParameterSetMetaData;
-import org.apache.derby.impl.jdbc.EmbedPreparedStatement;
 import org.apache.derby.impl.jdbc.EmbedSQLException;
-import org.apache.derby.impl.jdbc.EmbedStatement;
 import org.apache.derby.impl.jdbc.Util;
 
 class DRDAConnThread extends Thread {
@@ -3781,8 +3779,6 @@
 	 */
 	private void writeSQLRSLRD(DRDAStatement stmt) throws DRDAProtocolException,SQLException
 	{
-
-		EmbedPreparedStatement ps = (EmbedPreparedStatement) stmt.getPreparedStatement();
 		int numResults = stmt.getNumResultSets();
 
 		writer.createDssObject();
@@ -5900,13 +5896,7 @@
 	//pass PreparedStatement here so we can send correct holdability on the wire for jdk1.3
and higher
 	//For jdk1.3, we provide hold cursor support through reflection.
 	private void writeSQLDHROW (DRDAStatement stmt) throws DRDAProtocolException,SQLException
-	{
-		ResultSet rs = null;
-		EmbedStatement rsstmt;
-		if (!stmt.needsToSendParamData)
-			rs = stmt.getResultSet();
-		
-
+	{		
 		if (JVMInfo.JDK_ID < 2) //write null indicator for SQLDHROW because there is no holdability
support prior to jdk1.3
 		{
 			writer.writeByte(CodePoint.NULLDATA);



Mime
View raw message