Return-Path: Delivered-To: apmail-db-derby-commits-archive@www.apache.org Received: (qmail 30754 invoked from network); 5 Oct 2005 18:32:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Oct 2005 18:32:47 -0000 Received: (qmail 9964 invoked by uid 500); 5 Oct 2005 18:32:46 -0000 Delivered-To: apmail-db-derby-commits-archive@db.apache.org Received: (qmail 9938 invoked by uid 500); 5 Oct 2005 18:32:46 -0000 Mailing-List: contact derby-commits-help@db.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Derby Development" List-Id: Delivered-To: mailing list derby-commits@db.apache.org Received: (qmail 9926 invoked by uid 99); 5 Oct 2005 18:32:46 -0000 X-ASF-Spam-Status: No, hits=-9.8 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 05 Oct 2005 11:32:45 -0700 Received: (qmail 30553 invoked by uid 65534); 5 Oct 2005 18:32:25 -0000 Message-ID: <20051005183225.30546.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r295070 - in /db/derby/code/trunk/java: engine/org/apache/derby/iapi/types/ testing/org/apache/derbyTesting/functionTests/master/ Date: Wed, 05 Oct 2005 18:32:24 -0000 To: derby-commits@db.apache.org From: bandaram@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: bandaram Date: Wed Oct 5 11:32:16 2005 New Revision: 295070 URL: http://svn.apache.org/viewcvs?rev=295070&view=rev Log: DERBY-392: Disable creating b-tree indexes on long varchar for bit data. This datatype requires different kind of index and allowing the current behavior causes may issues. Submitted by Satheesh Bandaram (satheesh@sourcery.org) Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/aggbuiltin.out db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/bit.out db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java?rev=295070&r1=295069&r2=295070&view=diff ============================================================================== --- db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java (original) +++ db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java Wed Oct 5 11:32:16 2005 @@ -1245,6 +1245,7 @@ case StoredFormatIds.NATIONAL_LONGVARCHAR_TYPE_ID: case StoredFormatIds.LONGVARCHAR_TYPE_ID: case StoredFormatIds.XML_TYPE_ID: + case StoredFormatIds.LONGVARBIT_TYPE_ID: return false; case StoredFormatIds.USERDEFINED_TYPE_ID_V3: Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/aggbuiltin.out URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/aggbuiltin.out?rev=295070&r1=295069&r2=295070&view=diff ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/aggbuiltin.out (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/aggbuiltin.out Wed Oct 5 11:32:16 2005 @@ -756,8 +756,7 @@ 1 ----------- ij> select count(lbv) from empty group by lbv; -1 ------------ +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> select count(dc) from empty group by dc; 1 ----------- @@ -924,11 +923,7 @@ 0 WARNING 01003: Null values were eliminated from the argument of a column function. ij> select count(lbv) from t group by lbv; -1 ------------ -15 -0 -WARNING 01003: Null values were eliminated from the argument of a column function. +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> select count(dc) from t group by dc; 1 ----------- Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/bit.out URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/bit.out?rev=295070&r1=295069&r2=295070&view=diff ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/bit.out (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/bit.out Wed Oct 5 11:32:16 2005 @@ -260,14 +260,7 @@ ff |ff |ff NULL|null |null columns ij> select vb16, c20, cv20, lbv from t order by lbv; -VB16|C20 |CV20 |LBV -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- - |0 |zero length column | -01 |1 |1 |0000000001 -03 |3 |3 |03 -ff |ff |ff |1111111111 -aa |aa |aa |aa -NULL|null |null columns |NULL +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> select b10 from t where b10 > X'0000000010'; B10 ---------------------------------------- Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out?rev=295070&r1=295069&r2=295070&view=diff ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out Wed Oct 5 11:32:16 2005 @@ -248,11 +248,7 @@ NULL ij> -- grouping by long varchar [for bit data] cols should fail in db2 mode select lbv from t group by lbv order by lbv; -LBV --------------------------------------------------------------------------------------------------------------------------------- -1234 -abcd -NULL +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> -- multicolumn grouping select i, dt, b from t where 1=1 group by i, dt, b order by i,dt,b; I |DT |B Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out?rev=295070&r1=295069&r2=295070&view=diff ============================================================================== --- db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out (original) +++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/implicitConversions.out Wed Oct 5 11:32:16 2005 @@ -1881,7 +1881,7 @@ ij> create index all1_bv on all1(bv); 0 rows inserted/updated/deleted ij> create index all1_lbv on all1(lbv); -0 rows inserted/updated/deleted +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> create index all1_dt on all1(dt); 0 rows inserted/updated/deleted ij> create index all1_tm on all1(tm); @@ -3338,7 +3338,7 @@ ij> create index all1_bv on all1(bv); 0 rows inserted/updated/deleted ij> create index all1_lbv on all1(lbv); -0 rows inserted/updated/deleted +ERROR X0X67: Columns of type 'LONG VARCHAR FOR BIT DATA' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type. ij> create index all1_dt on all1(dt); 0 rows inserted/updated/deleted ij> create index all1_tm on all1(tm);